coopernurse / barrister-go Goto Github PK

main() is defined several times in that package, as well as CalculatorImpl. It looks like it's intended to be a documentation package, but as files are have .go extension, you can't run go test ./... in the root of the repository.

Related to #4

I think this repository will be cleaner and clearer if all Iris-related stuff was extracted to an external repository, like barrister-go-iris. Iris support is completely decoupled from the main logic of barrister-go package and it only makes support more complex as you need to install those packages in order to run a simple go test ./...

Clients often need to connect to servers who may be using self-signed certificates. Currently Barrister uses the default http.Client which means connecting to these servers will fail. It would be useful to be able to pass in a custom Transport.

Here is how I have fudged things for now in barrister.go:

func (t *HttpTransport) Send(in []byte) ([]byte, error) {
...
tr := &http.Transport{
  TLSClientConfig: &tls.Config{InsecureSkipVerify : true},
}

client := &http.Client{ Transport: tr  }

The test.sh script generates conform server & client, but they are not documented so a newcomer doesn't have any clue of what they are for and how are they used. Could you give a one liner explanation of it?