Giter Club home page Giter Club logo

convertkit-paid-memberships-pro's People

Contributors

growdev avatar

Stargazers

avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

contemplate forkkit strangerstudios ajmorris

convertkit-paid-memberships-pro's Issues

Add i18n

  • add languages folder
  • add pot file
  • verify strings are translatable
  • verify textdomain

Update fields, cleanup text.

Related to #7. Refactor how entries are sent over.

Line 350 of /admin/class-convertkit-pmp-admin.php combines first and last names before sending to Convertkit. Convertkit has changed to use the name field as only the first name for each person. I’m hoping you can update the plugin to reflect this change.
Also, since I’m here the admin form language references adding a form, but this field was removed from the admin. It reads, “Add your API key below and then choose a default form to add subscribers to.” when it should be “Add your API key below.”

ref: https://wordpress.org/support/topic/name-update/

Deactivate PMPro and some ugliness ensues

Steps to recreate

  1. This plugin and PMPro are both enabled
  2. Disable PMPro
  3. Debug log ugliness below:
[06-Jul-2016 15:55:06 UTC] PHP Notice:  Undefined property: wpdb::$pmpro_membership_levels in /Users/daniel/sites/convertkit/wp-includes/wp-db.php on line 684
[06-Jul-2016 15:55:06 UTC] PHP Stack trace:
[06-Jul-2016 15:55:06 UTC] PHP   1. {main}() /Users/daniel/sites/convertkit/wp-admin/plugins.php:0
[06-Jul-2016 15:55:06 UTC] PHP   2. require_once() /Users/daniel/sites/convertkit/wp-admin/plugins.php:10
[06-Jul-2016 15:55:06 UTC] PHP   3. do_action() /Users/daniel/sites/convertkit/wp-admin/admin.php:168
[06-Jul-2016 15:55:06 UTC] PHP   4. call_user_func_array:{/Users/daniel/sites/convertkit/wp-includes/plugin.php:525}() /Users/daniel/sites/convertkit/wp-includes/plugin.php:525
[06-Jul-2016 15:55:06 UTC] PHP   5. ConvertKit_PMP_Admin->register_settings() /Users/daniel/sites/convertkit/wp-includes/plugin.php:525
[06-Jul-2016 15:55:06 UTC] PHP   6. ConvertKit_PMP_Admin->get_pmp_membership_levels() /Users/daniel/code/convertkit/convertkit-paid-memberships-pro/admin/class-convertkit-pmp-admin.php:114
[06-Jul-2016 15:55:06 UTC] PHP   7. wpdb->__get() /Users/daniel/code/convertkit/convertkit-paid-memberships-pro/admin/class-convertkit-pmp-admin.php:315
[06-Jul-2016 15:55:06 UTC] WordPress database error You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY id ASC' at line 1 for query SELECT * FROM  ORDER BY id ASC made by require_once('wp-admin/admin.php'), do_action('admin_init'), call_user_func_array, ConvertKit_PMP_Admin->register_settings, ConvertKit_PMP_Admin->get_pmp_membership_levels
[06-Jul-2016 15:55:13 UTC] PHP Notice:  Undefined property: wpdb::$pmpro_membership_levels in /Users/daniel/sites/convertkit/wp-includes/wp-db.php on line 684
[06-Jul-2016 15:55:13 UTC] PHP Stack trace:
[06-Jul-2016 15:55:13 UTC] PHP   1. {main}() /Users/daniel/sites/convertkit/wp-admin/plugins.php:0
[06-Jul-2016 15:55:13 UTC] PHP   2. require_once() /Users/daniel/sites/convertkit/wp-admin/plugins.php:10
[06-Jul-2016 15:55:13 UTC] PHP   3. do_action() /Users/daniel/sites/convertkit/wp-admin/admin.php:168
[06-Jul-2016 15:55:13 UTC] PHP   4. call_user_func_array:{/Users/daniel/sites/convertkit/wp-includes/plugin.php:525}() /Users/daniel/sites/convertkit/wp-includes/plugin.php:525
[06-Jul-2016 15:55:13 UTC] PHP   5. ConvertKit_PMP_Admin->register_settings() /Users/daniel/sites/convertkit/wp-includes/plugin.php:525
[06-Jul-2016 15:55:13 UTC] PHP   6. ConvertKit_PMP_Admin->get_pmp_membership_levels() /Users/daniel/code/convertkit/convertkit-paid-memberships-pro/admin/class-convertkit-pmp-admin.php:114
[06-Jul-2016 15:55:13 UTC] PHP   7. wpdb->__get() /Users/daniel/code/convertkit/convertkit-paid-memberships-pro/admin/class-convertkit-pmp-admin.php:315
[06-Jul-2016 15:55:13 UTC] WordPress database error You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY id ASC' at line 1 for query SELECT * FROM  ORDER BY id ASC made by require_once('wp-admin/admin.php'), do_action('admin_init'), call_user_func_array, ConvertKit_PMP_Admin->register_settings, ConvertKit_PMP_Admin->get_pmp_membership_levels

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.