convertkit / convertkit-gravity-forms Goto Github PK

When the CK API key is blank

then the site admin goes to a Form > Settings > ConvertKit > Add there is a fatal error:

[02-May-2018 17:27:53 UTC] PHP Fatal error:  Uncaught Error: Cannot use object of type WP_Error as array in /Users/daniel/code/convertkit/convertkit-gravity-forms/components/gravityforms/class-gf-convertkit.php:278
Stack trace:
#0 /Users/daniel/code/convertkit/convertkit-gravity-forms/components/gravityforms/class-gf-convertkit.php(136): GFConvertKit->get_custom_fields()
#1 /Users/daniel/sites/convertkit/wp-content/plugins/gravityforms/includes/addon/class-gf-feed-addon.php(1294): GFConvertKit->feed_settings_fields()
#2 /Users/daniel/sites/convertkit/wp-content/plugins/gravityforms/includes/addon/class-gf-feed-addon.php(1096): GFFeedAddOn->get_feed_settings_fields(Array)
#3 /Users/daniel/sites/convertkit/wp-content/plugins/gravityforms/includes/addon/class-gf-feed-addon.php(1041): GFFeedAddOn->feed_edit_page(Array, '0')
#4 /Users/daniel/sites/convertkit/wp-content/plugins/gravityforms/includes/addon/class-gf-addon.php(4190): GFFeedAddOn->form_settings(Array)
#5 /Users/daniel/sites/convertkit/wp-includes/class-wp-hook.php(286): GFAddOn->form_settings_pag in /Users/daniel/code/convertkit/convertkit-gravity-forms/components/gravityforms/class-gf-convertkit.php on line 278

This customer:
https://wordpress.org/support/topic/php-fatal-error-uncaught-error-cannot-use-object-of-type-wp_error-as-array/

Reported that in this api call a WP_Error was returned.

This can be caused by not having an API Key entered in the settings page, or a connectivity issue between the website and the CK API server.

Either way, there should be some better error handling when a WP_Error happens communicating to the CK API.

This is because an array is added to $base_fields['fields'] for custom field mappings in GFConvertKit::feed_settings_fields() regardless of if the connected account has any custom fields.

• Add package.sh script from main ConvertKit plugin
• Add .distignore file for building release and leaving out unneeded files/dirs (package.json, etc.)

If a form's Name (Full) field is used in feed settings, it will not be sent to ConvertKit and will generate a PHP notice.

This is because the value of the Name (Full) field is determined after form submission; it's not an actual <input> in the form, but we're currently trying to access it directly here.

Add a review request notification similar to the main ConvertKit Plugin.

Copy API class and unit tests from the main ConvertKit Plugin into this one.

The plugin is incompatible with Gravity Forms 2.5+. When creating a feed and selecting a form, the dropdown is blank.

DevTools logs the following error:

Uncaught ReferenceError: gform is not defined
at admin.php?page=gf_edit_forms&view=settings&subview=ckgf&id=2&fid=0:3

Uncaught ReferenceError: gform is not defined
at admin.php?page=gf_edit_forms&view=settings&subview=ckgf&id=2&fid=0:15```

Add mapping of Gravity Form fields to ConvertKit custom fields.

Currently, when setting up a form feed, the name field is required. For forms that only have an email address, this causes a problem, because the user is forced to map the visitor-given email address to the name field. Then, their subscriber record in ConvertKit has their email address as both their email and name.

The fix is to not make the name field mapping required.

Use case:
A form has a select and use the select's value as a tag passed to the subscribe.

ref: PS slack convo with @JiveDig

The Advanced Name fields in GF adds a few options:

• Name (Full)
• Name (First)
• Name (Last)

Test and verify this is working correctly.

• add languages folder
• add pot file
• verify strings are translatable
• verify textdomain

Notice: Undefined index: url in /Users/travis/Sites/ck/wp-content/plugins/convertkit-gravity-forms/components/gravityforms/class-gf-convertkit.php on line 280

This is because the current code expects ConvertKit forms to have a url parameter, but only some do.

Customer got this when accessing CK Settings page in Gravity Forms:

Fatal error: Cannot use object of type WP_Error as array in /html/wp-content/plugins/convertkit-gravity-forms/components/gravityforms/class-gf-convertkit.php on line 164

Try to recreate.

Ref: https://secure.helpscout.net/conversation/312320855/53806/?folderId=956509

Improve test performance similar to the main ConvertKit Plugin.

Review and update plugin documentation.

ref: https://secure.helpscout.net/conversation/507121731/159636?folderId=956509

Request:

In a multipage form (generated in gravity forms), each page has a "next" buttons and contains for example:
form page 1: name, email
form page 2: demographic data
form page 3: product interest data
form page x: other

Gravity forms has an addon that collects data from each "next" button click = partial entry

And convertkit has an addon that sends the COMPLETE set of data from the form back to convertkit subscriber profile (when hitting the send buttton at the end of the form only, not when hitting "next").

I want to send the data at each click, even when prospects don't complete the totality of the multipage form.

ref: https://secure.helpscout.net/conversation/549470280/193810/