contao / calendar-bundle Goto Github PK

Abridged reproduction:

1. Create a new event.
2. Set Redirect target to External URL.
3. Set Link target to https://www.google.com/.
4. Create an Event list module and set the Event template to event_teaser.
5. Integrate the module somewhere in the front end.
6. Open the front end.

The headline of the created event will not be linked. Also there will be no Read more… link. Thus you are unable to actually go the the external URL.

Tested with Contao 4.4.12. Same problem exists in Contao 3.5.31 probably.

Cause

This is caused by these lines:

// Show the teaser text of redirect events (see #6315)
if (\is_bool($event['details']))
{
    $objTemplate->hasDetails = false;
}

This is a problem for the event_teaser template, since it will only show links when hasDetails is true. The other templates like event_list or event_upcoming always create a link, regardless of hasDetails.

The current behaviour is inconsistent with the news module. In the news module, the headline is linked when it is an external redirect and the default news_latest template shows a Read more… link as well, when the news entry is an external redirect.

While you can leave the end-date empty you have to set a end-time to leave it open. This is confusing and not consequent. I suggest to leave the end-time empty too if it is not used!

If you change the start-time you every time have to set the end-time again if you want to leave it open!

Hello Contao team,

to get the events shown in Google search results, at least the "location" field should be added with microdata, because this is a required field (from Google perspective). Currently the location is only published as plain HTML text (at least in the Demo).

Please also see the errors in the Google Structured Data Testing Tool with Contao example event page - the missing location is throwing an error.

Besides that: Is there a reason why the event pages in Contao are so... "basic"? To have a useful events component with correct microdata support, it should be possible to prepare different locations in a separate content table (to avoid duplicate content in the CMS and the microdata could be used directly from the locations entries) and also have some more fields eg for performers, door time, event status and much more, see event on schema.org with many examples... Also an option to select the type of the event would be usefull (MusicEvent, BusinessEvent, ChildrenEvent, Festival, SportsEvent...)

Or is this all ment to be added by external plugins and extensions? If so, why is the calendar and events module part of the core and not an optional module? (I'm not against the calendar module, I just want to know why it is so basic and rudimentary).

Thank you all for your great Contao work and effords!

Unabhängig, ob in der Modulkonfiguration dieses Flag aktiviert ist oder nicht, werden laufende Events immer angezeigt.
Beim Format ist ansonsten eingestellt: "All upcoming events" (Alle zukünftigen Events).
Getestet unter Contao 4.4.18 und 4.5.8 in der Contao-Demo.

Wird einer Veranstaltung eine Startzeit gegeben muss wohl auch eine Endzeit eingegeben werden.
Möchte man nun aber keine Endzeit im Frontend ausgeben löscht man den Eintrag ja wieder im Backend.
Nach dem Speichern steht dann nun aber ein 01:00 und wird auch so im Frontend als Endzeit ausgegeben.

Im Frontend erscheint nur keine Endzeit, wenn Endzeit = Startzeit.
Ist denn eine Endzeit zwingend?

Reproduzierbar in der Demo:

• Neues Event anlegen.
• Haken bei "Zeit hinzufügen" setzen
• Starzeit eintragen
• Endzeit löschen
• speichern
• Endzeit ansehen

Wenn bei einer Veranstaltung die Endzeit auf 01:00 Uhr gesetzt wird, dann wird das nach dem Speichern einfach wieder entfernt.
Das hängt wohl hiermit zusammen:
https://github.com/contao/calendar-bundle/blob/4.x/src/Resources/contao/dca/tl_calendar_events.php#L777

Das ist echt ungünstig, da das Event nun mal leider um 01:00 Uhr endet. Also was nun machen? Kann ja schlecht einstellen, dass es dann 01:01 Uhr endet :D

Das ganze ist reproduzierbar in der Demo. Unsere Installation ist übrigens auch Contao 4.9

The Google Test Tool for strucutred data (https://search.google.com/structured-data/testing-tool/u/0/?hl=de#url=https%3A%2F%2Fwww.alfeld-rockt.de%2F) has some errors with my event.

The one I want to address with this issue: Google wants one image tag, however it does not want the associatedImage tag.
Do we want to change labels?

Now that @fritzmg has debugged the memory issues caused by eagerly loaded models, I want to discuss eager loading in general. Take this code for example:

With array('eager'=>true) we instruct Contao to also load all related models. Here's what we get:

• ArticleModel
• PageModel (pid)
• UserModel (author)

However, we are not using the UserModel in this case, so we would not have needed to create it. On the other hand, using array('eager'=>true) has saved us one additional database query.

@contao/developers Would you prefer having more database queries and no unneeded models over having less database queries and potentially unneeded models?

Wenn ich ein Modul vom Typ Eventliste erstelle und als Anzeigeformat "Alle Events" Wähle, dann gehen die URL-Parameter vom Event-Menü nicht.

Ist das so erwünscht ? Bin heute das erste mal drüber gestolpert...

In the news module you can star out/highlight news but not in the event module.

The highlighting feature is a great feature to show specific items of an archive on a page like the homepage for example. Why not use this advantage for higlighting events at a specific page?

the enclosure should be sortable like the downloads in the content

After updating calendar-bundle from 4.3.0 to 4.3.1 in event list modul upcoming events are not displayed anymore.

There are different opinions on how to deal with running events as they are not "upcomming" and not "past".
i suggest to add a checkbox as described here

Here's the page example. Should be added on bothtl_calendar and tl_calendar_event, imho.

// Tag the response
if (System::getContainer()->has('fos_http_cache.http.symfony_response_tagger'))
{
    /** @var ResponseTagger $responseTagger */
    $responseTagger = System::getContainer()->get('fos_http_cache.http.symfony_response_tagger');
    $responseTagger->addTags(array('contao.db.tl_page.' . $objPage->id));
}

If you mix calendars in the eventlist module the classes in the html markup are always "first" and "last". But the first element should have the class "first" and the last element "last" independent of the mixed calendars.

By the way. The even and odd classes are also set wrong. It's every time "even".

Here are the settings from the module:

Contao 4.4.13