go1.4.2 compatibility about skopeo HOT 9 CLOSED

https://github.com/mtrmac/skopeo/tree/go142 , but please do not merge this. Let those who need to build against the old version apply this manually.

from skopeo.

Correct, let's keep this open for a while. I'll close it as soon as we switch to go 1.5+ in at least RHEL
Thanks

from skopeo.

This is now failing in CAHC: https://ci.centos.org/job/atomic-rdgo-centos7/lastSuccessfulBuild/artifact/build-logs/build-logs/failed/skopeo/build.log

from skopeo.

@cgwalters then I think this patch https://github.com/mtrmac/skopeo/tree/go142 needs to be applied - same as we do for RHEL

from skopeo.

The patch strategy doesn't really work with the idea of continuous delivery, which is what CAHC is trying to do. At least nontrivial patches to code which is likely to change.

I can freeze for now, but it seems clear that we need to pull in a newer golang. This would be a good on-list discussion.

from skopeo.

I can freeze for now, but it seems clear that we need to pull in a newer golang. This would be a good on-list discussion.

great

from skopeo.

Okay, last commit in CentOS/sig-atomic-buildscripts#85 : CentOS/sig-atomic-buildscripts@93d09a1

BTW, I think this is a cool aspect of rpmdistro-gitoverlay: I can trivially unwind to arbitrary commits both upstream and dist-git. I picked those commits by looking at the last successful build.

from skopeo.

#47 via #46 will hopefully prevent such breakage to be merged in the future; for now I am rather unhappy with the loss of functionality required in the go142 branch.

from skopeo.

As of https://rhn.redhat.com/errata/RHSA-2016-1538.html / https://lists.centos.org/pipermail/centos-announce/2016-August/022005.html , CentOS has golang 1.6.3 , so this is no longer relevant.

Attaching a diff showing the necessary code and build machinery changes (and parts of #46), purely for long-term archival before I delete the branches.
go142.patch.txt

from skopeo.