Giter Club home page Giter Club logo

tms's People

Contributors

congthien avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

Forkers

mtndev

tms's Issues

Doublecheck the spelling of product thumb function in fix

Hi I was just doublechecking the issue #1 and saw that issue #8 comes up: the fix spells the thumbnail function with tms but I checked and that function isn't defined anywhere and it's instead spelled tsm. So I think one or the other needs to be updated so they match. It'd be great if you have a way to do a global search/replace so you can make them all the same. Couldn't you search for everything that has tsm and change it to tms? That wouldn't break anything right?

Just wanted to check. Thanks!

image

In template-frontpage.php https://github.com/congthien/tms/blob/00ed5cf1687a9959b11ad829794fe811eac8bfde/template-frontpage.php

image

Homepage WC Products need to have rectangular dimensions

The products this client will list are books. The thumbnails will be the cover of the book which is rectangular. Is this something that will automatically adjusted based on the uploaded product image?

Just wanted to doublecheck with you.

Thanks!

Here's the screencap from the HTML mockup:

image

Here's the screencap of the current WP theme:

image

Logo in mobile header

The logo should be in the mobile header so users have a way to navigate back to the homepage from a subpage.

Here's the mobile header in the HTML:

image

Here's how it is in the current version of the WP template:

image

Question: How are the Partners logos added

The customizer has a place for the Partners text but I don't see anything for the images. Just let me know if I should add these manually to the page template or how you had planned for them to be updated.

Thanks!

image

functions and code switches between "tms" and "tsm" for prefixes

This might not matter at all since everything is working great, but it might cause some confusion in maintaining things later. if it's a quick fix now, it might be worth it. Open to your feedback.

TMS is the correct way (for The Masonry Society). Thanks!

image

Homepage Latest News not pulling news posts correctly

Hi Kien and David-on the TMS theme on my site http://2tms.robidev.com/ the front page "Latest News" section isn't displaying the latest posts correctly. I'm not sure why. It looks like it's working fine on your demo site, so I'm not sure what the difference is. Is it something you can look at or should I try re-importing your test site? My client has added content already, so I'm not sure what the best approach is at this point. I could use your help.

Thanks,

Valerie

Errors in the post meta box

I wanted to test the rectangular product images to make sure that this is working as expected. So I opened a product and edited the featured image using the post editor and only cropping the thumbnail. In the product gallery meta box there are some errors now that look related to the issue #9 . I don't see these errors when I apply the crop to all image sizes. So maybe when that gets fixed they will go away but I thought I ought to check w/ you to make sure.

Thanks!

http://demo.famethemes.com/tms/wp-admin/post.php?post=143&action=edit

image

Post Breadcrumbs

Are the post breacrumbs live? They display the same text as the HTML mockup rather than the current post title, so I just wanted to check. I will have Yoast's SEO plugin on the production site, so if you're familiar with using that, that would be a great option for me. I'm open to whatever works best for you though.
image

Mobile Nav Menu

How are the mobile nav menu items determined? It looks like this is currently set to be the same as the Primary Menu. I think that the client might need the option to have some different menu items on mobile that are not the same as the Primary Menu.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.