Giter Club home page Giter Club logo

conclave's People

Contributors

dependabot[bot] avatar elisejane avatar nitinsavant avatar sunny-b avatar unsudo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

conclave's Issues

npm run compile failes with Cannot find module './bufferbuilder'

In the postIntall script npm run compile is called which in turn calls browserify to compile build files in to bundles.
And all peerjs calls faile with following error

$ browserify build/demo.js -o public/js/demo-bundle.js && browserify build/idGraph.js -o public/js/idGraph-bundle.js && browserify build/timeGraph.js -o public/js/timeGraph-bundle.js && browserify build/arraysGraph.js -o public/js/arraysGraph-bundle.js

Error: Cannot find module './bufferbuilder' from '/home/schartz/code/conclave/node_modules/peerjs/dist'

at /home/schartz/code/conclave/node_modules/browser-resolve/node_modules/resolve/lib/async.js:55:21 at load (/home/schartz/code/conclave/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43) at onex (/home/schartz/code/conclave/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31) at /home/schartz/code/conclave/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47 at FSReqWrap.oncomplete (fs.js:152:21) error Command failed with exit code 1.

Any help would be greatly appreciated.

Same line writing is glitchy

Having a second user trying to write over first's existing line, results in bug at Firefox latest release 57.0.3 (64-bit): SecondUser's cursor lies stuck and updates stop showing at firstUser's screen.

license

Hi conclave team,
very interesting proof of concept.
I couldn't find licensing information, could you clarify?

LSEQ and causal tree

First of all thanks for a great writeup on the case study, it's very clear and easy to understand.

Just wondering the LSEQ data type you picked is any different from a causal tree? or they are essentially the same thing just in different names? Thanks.

Code highlight

I suggest to introduce a syntax coloring mechanism in the editor. Parallel coding is valuable, for example, when collaborating on a group task in college.

Since there is a text field, it seems that it is possible to enter the choice of syntax coloring and to color the text field.

Crdt lib

Thanks for a good write-up of how your system works. Very readable and clear !

I am interested in this area and have used y.js. it's good but not as comprehensive as your system.

I would like to write a golang version of your system. That will allow it to run on mobiles but also in web browser as JavaScript and webassembly.
Let me know what you think.

Also I think we can also extend the file system to share and sync files stored in the browser in a db. I guess you might be thinking about that for the future ?

Anyway please let me know ..

Error with making a call

Got this error while trying to stream video. And another one was caught as well. CC @sunny-b

image
image

Errors were present in both Chrome and Firefox.

Wrap lines

It would be cool, if the user can set line wrapping to on. If conclave could then persist that as a user setting (localStorage?) that would be even better!

Chrome 63 indefinite waiting

There's a bug in Chrome 63 where, if a new user joins via copy/paste link in browser, they will not connect to other users and editor will load indefinitely.

This does not occur when pressing "Command" and clicking on the "Sharing Link" link to open a new tab. Opening up chrome dev tools and/or creating breakpoints also seems to fix it for some odd reason.

Not sure what's going on.

Adblock Plus can hide sharing link

When Adblock Plus has the "Block social media icons tracking" option enabled, it injects a stylesheet that, among other things, explicitly sets display: none !important on any element with the class .sharing-link. This causes the sharing link to be hidden in Conclave (and is really not Conclave's fault at all).

As far as I can tell, the class .sharing-link is only referenced once in the code base, to set display: inline-blockβ€”it might be worth changing the class name or targeting the element in another manner.

Plain text option

Please support an option for non-markdown.

eg I want to teach some bash to a remote user, but the comments are converted to heading!

Insertions latency and fractional position conflicts

I was wondering what case this line of code should cover. Is that related to fractional position conflicts between multiple editors?
How Conclave behaves when an insert message comes after locally inserting a symbol with the same fractional position of the character coming from the message. I mean, shouldn't all the editors follow the same fractional position ordering? If the algorithm just searches for the position before and after the character, will the state between editors be broken?

Publish links

StandardNotes, CryptPad, HackMD, most editors support publishing a pretty formatted version of docs meant for viewing only. Would be nice here as well

Firefox New Line bug

This is probably related to #3

In Firefox, when editing on the same line, if a user types in a new line character, it isn't reflected on the other users screen and both users will be off by 1 line.

This is either due to either how CodeMirror acts in Firefox, as this is not an issue we see in Chrome or a bug in the updateRemoteCursors logic that is in the Editor class. That logic can be pretty tricky and finicky as there are many edge cases.

Will check it out if there is time, though anyone else is welcome to tackle it as well.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.