compulim / azure-storage-fs Goto Github PK

👍 Everyone can see build progress
👎 No code coverage report, and poor test result visualization

Faster tests

I am using azure-storage-fs as the filing system for my ftpd implementation. I can connect to the azure storage, upload a file and read the directory when empty, however when a file exists in the container I get the following error when getting the directory listing via fileZilla:

TypeError: unexpected "file type"
    at Mode.toString (/usr/src/app/node_modules/stat-mode/index.js:91:11)
    at whenReady (/usr/src/app/node_modules/ftpd/lib/FtpConnection.js:612:57)
    at FtpConnection._whenDataReady (/usr/src/app/node_modules/ftpd/lib/FtpConnection.js:155:7)
    at /usr/src/app/node_modules/ftpd/lib/FtpConnection.js:579:12
    at afterWrite (_stream_writable.js:464:3)
    at _combinedTickCallback (internal/process/next_tick.js:144:20)
    at process._tickCallback (internal/process/next_tick.js:180:9)

My connection code is:

    if (pass) {
      success(username, require('azure-storage-fs').blob(
        blobAccountName,
        blobSecret,
        containerName));
      // success(username);
    } else {
      failure();
    }
  });

Looking at stat-mode, it can't determine the type of the file (ie. isDirectory(), etc) and falling through to this exception.

The container I am testing has 1 file and is a block blob type and I have attempted this with classic storage, storage v1 and storage v2.

Any help would be greatly appreciated

My dependancies are

  "dependencies": {
    "async": "^2.6.0",
    "azure-storage": "^2.8.1",
    "azure-storage-fs": "^0.4.0",
    "bluebird": "^3.4.1",
    "debug": "^2.2.0",
    "deep-assign": "^2.0.0",
    "ftpd": "nodeftpd/nodeftpd",
    "dateformat": "1.0.7-1.2.3",
    "stat-mode": "^0.2.2"
  },

At https://github.com/compulim/azure-storage-fs/blob/master/lib/AzureBlobFS.js#L15, promisifyhelper should be case sensitive.

Cannot find module './util/promisifyhelper' from 'AzureBlobFS.js'
      
  at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:191:17)
  at Object.<anonymous> (node_modules/azure-storage-fs/lib/AzureBlobFS.js:11:37)

listBlobsSegmentedWithPrefix is nice, we should add prefix to options in readdir.

https://github.com/compulim/azure-storage-fs/blob/master/lib/AzureBlobFS.js#L57

Instead of accepting strictly BlobService, accept likeys. Maybe createContainer is a good check, or list what we need.

• lib should be src.
• package.json should whitelist files
• Use Babel and embrace ES6
• Separate functions into different files
  • Enable better testability

As Promise is now on ES6, we no longer need bluebird.

Am I missing something?

Currently, showing quirkiness of API as a way to list our APIs is kind of bad.

Everything is working fine when running it locally.

When I deployed this to an Azure VM the server hangs when listing the directory.

Remove doWhilst and whilst, replace with async/await.

Usage:

const azureStorage = require('azure-storage');
const blobService = azureStorage.createBlobService();

require('azure-storage-fs').blob(blobService);