Giter Club home page Giter Club logo

Comments (4)

jessicarose avatar jessicarose commented on May 26, 2024

Hi @gtbot2007 and thanks so much for raising this issue, could I get a bit more detail in what's preventing uncommon letters from being used? Is this a limitation you've found in the guidelines that could be better clarified or are you getting a bug or error message when trying to input sentences that contain words like "yupekosi", "Pingo" and "kalamARR"?

from common-voice.

HarikalarKutusu avatar HarikalarKutusu commented on May 26, 2024

I believe at least the last one happens because of the default validation rules defined below, which tries to handle abbreviations:

For other cases you need to create language specific validation rules, like the ones here:
https://github.com/common-voice/common-voice/tree/main/server/src/core/sentences/validation/languages

from common-voice.

gtbot2007 avatar gtbot2007 commented on May 26, 2024

Since they are used so few words and the words are also ”non-standard” they are considered foreign letters. Which is technically true but maybe there should be a case to allow the words “Pingo”, “yupekosi”, “kalamARR”, “yutu” and maybe even “yu” and “y”.

from common-voice.

HarikalarKutusu avatar HarikalarKutusu commented on May 26, 2024

Sorry for the noise, I posted before checking. There IS actually a tok validation file here:
https://github.com/common-voice/common-voice/blob/main/server/src/core/sentences/validation/languages/tok.ts

It seems, each one of the samples you gave is hitting one regex rule there. Either they are not wanted, or the regex rules might need tweaks.

from common-voice.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.