[BUG] Sentence collector: Review process produces 429 Too Many Requests too quickly with no clear error indication about common-voice HOT 10 CLOSED

I should add I see this as a severe bug as it is currently limiting the rate at which we can approve sentences for my language!

from common-voice.

Hello @kwikwag thanks for filing this issue.

This is not a bug but something we did intentionally to limit the rate at which the API is called when reviewing sentences. The limit with which you can call the API is one every 3 seconds so try to keep your contributions within that limit.

Thanks

from common-voice.

Hey @moz-rotimib - something must be wrong in your calculation - currently the rate is set at 12 requests per 60 seconds, which is one request every 5 seconds. This is seriously limiting the throughput and discourages participation. The rate should be limited according to how normal people work. I does not take 5 whole seconds to read a short (under 15 words) sentence and decide if it is valid. If you stop people before even a minute elapses they will quickly become discouraged and stop volunteering.

Was there any preliminary work done to check what's the distribution of request times for most users to see how this might negatively impact current users?

It seems to be quite simple and sensible to reduce this limit to one request every 2 seconds. Intuitively it should support most use-cases without compromising the limits required to maintain service quality. Especially when it comes to the Sentence Review part.

from common-voice.

I just now performed a session of sentence review. First request Sat, 15 Jul 2023 21:09:36 GMT. The 11th request at Sat, 15 Jul 2023 21:10:24 GMT received a 429 Too Many Requests with Retry-After: 12. That is, I need to wait for a minute to elapse in order to complete 11 requests. That's actually 10 requests per 60 seconds, which is 6 seconds between requests - double the interval from what you wrote...

from common-voice.

Adding a screenshot to help visualize this. Notice the timeline and the position of the failing request.

from common-voice.

Oh and last P.S. @moz-rotimib the bug is also the fact that there is no indication of error on the page whatsoever (see original screen recording)

from common-voice.

Hi @kwikwag , thank you for putting so much effort into this issue. We adjusted the rate limit to 2s for sentence reviews as suggested (#4118). It will go live with the next release 🎉

from common-voice.

Oh and last P.S. @moz-rotimib the bug is also the fact that there is no indication of error on the page whatsoever (see original screen recording)

Thanks for also pointing this out. We have created a ticket to fix this and we will work on this in the coming weeks

from common-voice.

Thank you for your efforts and for listening!

from common-voice.

I had that reported also here: #4091 , so I'm closing that one.

from common-voice.