committhis / black-box-bmv2 Goto Github PK

As per title

If exceptions are thrown in some cases, it will bring down the entire test suite, without properly cleaning up. Consequently, the following may not be removed:

• Container network namespace link;
• Virtual ethernet pairs
• Docker container

There is a lot of set up and tear down to be done with a complete example. The most significant of these is the SimpleSwitchRunner. If we used a context manager, we could (hopefully) gracefully rollback everything that was set up.

For simplicity's sake, the code could look like:

pkt = Ether(src=get_if_hwaddr('h1eth0'), dst='ff:ff:ff:ff:ff:ff')/IP(
        src='10.0.0.1',
        dst='255.255.255.255')/ICMP()

context = TestContext()

with make_switch(config, name, network, port) as switch:
    result1 = context.expect('h2eth0', saw_packet_equals_sent(pkt))

# and so on....

However, we could also do something similar with the TestContext, and I'm not sure what the correct pattern would be with multiple nested inline context managers. There's also a lot of other moving machinery, so some thought would want to be had here.

Possible QOL change. Rather than have a user filter gRPC messages from the switch, provide an interface that only returns digest messages. However would need to be considered against a users need to accept other messages, such as arbitration updates etc.