Giter Club home page Giter Club logo

Comments (2)

colinmollenhour avatar colinmollenhour commented on July 21, 2024

With logLevel < 6 that change should have 0 effect and even with logLevel >= 6 I think the difference would be negligible. The slowest code would be the block at line 232 but that only occurs when there is lock contention so it can't itself be the initial cause of the lock contention...

I used to fret over having broken locks and such but finally just started ignoring such errors (as long as there isn't a huge sudden increase) and everything seems fine.. So what do you mean exactly when you say "a lot"?

One thing to keep in mind: The adminhtml media gallery feature generates thumbnails on the fly so if you open a folder that has a lot of images then your browser will be making many expensive requests to Magento all at once and is sure to cause lock contention. I think I edited the Magento core code on production (!!!) to close the session early after I got sick of seeing errors because of it.

from cm_redissession.

parhamr avatar parhamr commented on July 21, 2024

Oh, gosh—good point about logLevel. Disregard!

I’m not currently able to provide a good figure for frequency. The feature was deployed to production 8/3 but reverted on 8/7 because of other features in that same release.

I’ll take a look at this later, but largely consider it a non-issue :)

from cm_redissession.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.