Comments (4)
fredden
commented on August 22, 2024
I was able to fix this locally by making the following changes to the 2.4.0 tag. There doesn't appear to be a branch for the 2.x release line, so I can't open a pull request with this specific change. @colinmollenhour please can you create such a branch, or is the 2.x release line now unsupported?
diff --git a/app/code/local/Cm/RedisSession/Model/Session.php b/app/code/local/Cm/RedisSession/Model/Session.php
index 5c14563..e5428b2 100644
--- a/app/code/local/Cm/RedisSession/Model/Session.php
+++ b/app/code/local/Cm/RedisSession/Model/Session.php
@@ -39,6 +39,16 @@ if (is_dir(__DIR__.'/../lib/src/Cm/RedisSession')) {
require_once __DIR__.'/../lib/src/Cm/RedisSession/ConcurrentConnectionsExceededException.php';
}
+foreach (['/Cm_RedisSession_lib_src_Cm_RedisSession_ConcurrentConnectionsExceededException.php',
+ '/Cm_RedisSession_lib_src_Cm_RedisSession_ConnectionFailedException.php',
+ '/Cm_RedisSession_lib_src_Cm_RedisSession_Handler_ConfigInterface.php',
+ '/Cm_RedisSession_lib_src_Cm_RedisSession_Handler_LoggerInterface.php',
+ '/Cm_RedisSession_lib_src_Cm_RedisSession_Handler.php'] as $file) {
+ if (file_exists(__DIR__ . $file)) {
+ require_once __DIR__ . $file;
+ }
+}
+
class Cm_RedisSession_Model_Session implements \Zend_Session_SaveHandler_Interface
{
diff --git a/app/code/local/Cm/RedisSession/Model/Session/Handler.php b/app/code/local/Cm/RedisSession/Model/Session/Handler.php
index 08a5015..fa0f31e 100644
--- a/app/code/local/Cm/RedisSession/Model/Session/Handler.php
+++ b/app/code/local/Cm/RedisSession/Model/Session/Handler.php
@@ -39,6 +39,16 @@ if (is_dir(__DIR__.'/../../lib/src/Cm/RedisSession')) {
require_once __DIR__.'/../../lib/src/Cm/RedisSession/ConcurrentConnectionsExceededException.php';
}
+foreach (['/Cm_RedisSession_lib_src_Cm_RedisSession_ConcurrentConnectionsExceededException.php',
+ '/Cm_RedisSession_lib_src_Cm_RedisSession_ConnectionFailedException.php',
+ '/Cm_RedisSession_lib_src_Cm_RedisSession_Handler_ConfigInterface.php',
+ '/Cm_RedisSession_lib_src_Cm_RedisSession_Handler_LoggerInterface.php',
+ '/Cm_RedisSession_lib_src_Cm_RedisSession_Handler.php'] as $file) {
+ if (file_exists(__DIR__ . $file)) {
+ require_once __DIR__ . $file;
+ }
+}
+
class Cm_RedisSession_Model_Session_Handler extends \Cm\RedisSession\Handler
{
public function __construct()from cm_redissession.
colinmollenhour
commented on August 22, 2024
@fredden I created a branch no-composer based on 2.4.0 if you want to submit a PR. It could be optimized for non-compiler users by adding else { break; }.
Does using compiler benefit performance significantly at this point?
from cm_redissession.
fredden
commented on August 22, 2024
Thanks very much for this @colinmollenhour. I've opened a pull request including your suggestion for optimisation.
Does using compiler benefit performance significantly at this point?
I don't know. After making the change above locally, I encountered other modules which were similarly incompatible, so I couldn't test the impact properly without spending time fixing those too. The project I was working on was time-limited and has finished now. I'm unlikely to be able to revisit this feature in the short term.
Thanks too for making such a wonderful contribution to the platform over the years! This code runs on a very large number of websites these days.
from cm_redissession.
colinmollenhour
commented on August 22, 2024
You're quite welcome! Thanks for the PR! It is merged and tagged as 2.5.0.
from cm_redissession.
Related Issues (20)
- Connectivity issue with Azure Redis Cache HOT 1
- Configuration changes don't take effect HOT 3
- hard coded session expiry HOT 5
- Magento 1.7.0.2 and PHP 7.x HOT 1
- Passing glue string after array is deprecated. Swap the parameters in colinmollenhour/credis/Client.php on line 1414 HOT 4
- Cm\RedisSession\Handler::read taking more than 6sec HOT 14
- Session storage - Too many active connections HOT 2
- Tag current version master HOT 1
- Magento 2 switching to Laminas instead of Zend (ZF2) HOT 3
- Experiencing delay problems HOT 1
- PHP Warning: Module 'redis' already loaded in Unknown on line 0 HOT 1
- Make setSaveHandler() only callable once
- Separate read-only instance from read/write instance HOT 5
- missing ConfigInterface HOT 1
- Session IDs are plain text in redis (missing hash) HOT 1
- Native Magento Redis Session extension HOT 1
- 3.0.1 can not load the session model using composer HOT 10
- How can I install a specific version of this module via modman? HOT 4
- Error cleaning cache by mode matchingAnyTag: A pipeline is already in use and only one pipeline is supported. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cm_redissession.