Giter Club home page Giter Club logo

Comments (4)

JacobWeisenburger avatar JacobWeisenburger commented on June 19, 2024

Is this what you are looking for?

const numPlayersBase = z.number().int().min( 2 ).max( 100 )
type NumPlayers = z.infer<typeof numPlayersBase>
type RealNumPlayers = IRange<2, 100> // 2 | 3 | 4 | ... | 100
const numPlayers = z.custom<RealNumPlayers>( data => numPlayersBase.safeParse( data ).success )

If you found my answer satisfactory, please consider supporting me. Even a small amount is greatly appreciated. Thanks friend! 🙏
https://github.com/sponsors/JacobWeisenburger

from zod.

Zamiell avatar Zamiell commented on June 19, 2024

Hi Jacob,

Your answer is great in that it does indeed leverage the Zod validation. And one could easily add their own logic afterward.

However, I still think there is room for improvement. There would be no need to run base.SafeParse at all if custom existed on the method chain. In other words:

type NumPlayers = IRange<2, 100>; // 2 | 3 | 4 | ... | 100
const numPlayersBase = z.number().int().min(2).max(100);
const numPlayers = z.custom<RealNumPlayers>(data => numPlayersBase.safeParse(data).success);

versus

type NumPlayers = IRange<2, 100>; // 2 | 3 | 4 | ... | 100
const numPlayers = z.number().int().min(2).max(100).custom<NumPlayers>();

The second snippet is more concise and easier to read!

from zod.

JacobWeisenburger avatar JacobWeisenburger commented on June 19, 2024

So I'm gathering that you are wanting this to be a new feature instead of asking for a workaround, is that correct?

from zod.

Zamiell avatar Zamiell commented on June 19, 2024

Yes, this is a feature request issue.

from zod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.