Huge memory and performance gap between `parse` and `parseAsync` about zod HOT 4 OPEN

Thanks for the effort you put into this benchmark! I'm broadly aware of this and am working on solutions in Zod 4. There are some very obvious performance in Zod's current parsing pipeline that unfortunately will require breaking changes to fix.

I'll report back with updated performance numbers against this benchmark once Zod 4 is nearing beta.

from zod.

^I made a POC of not using ctx.async and instead detecting Promises during parsing. Here's the branch https://github.com/jussisaurio/zod/pull/1/files which currently is based on my other zod perf PR (#3487)

Results using your benchmark @warflash :

[email protected]:

Benchmarking with 1000 elements
Validation time sync: 25.703ms
Validation time async: 61.169ms

Benchmarking with 10000 elements
Validation time sync: 110.733ms
Validation time async: 641.032ms

Benchmarking with 50000 elements
Validation time sync: 592.054ms
Validation time async: 4.608s

Benchmarking with 100000 elements
Validation time sync: 1.541s
Validation time async: 13.151s

branch:

Benchmarking with 1000 elements
Validation time sync: 20.666ms
Validation time async: 11.56ms

Benchmarking with 10000 elements
Validation time sync: 113.841ms
Validation time async: 100.013ms

Benchmarking with 50000 elements
Validation time sync: 510.81ms
Validation time async: 512.89ms

Benchmarking with 100000 elements
Validation time sync: 1.056s
Validation time async: 1.188s

The reason sync/async are almost the same in the branch is that it doesn't extra wrap any promises. A more comprehensive benchmark would include stuff like async refines to see what the impact is

from zod.

Great, that sounds very nice!
Appreciate the reply and really looking forward to trying out the v4 beta then to see how it performs against our production ingests 😊

from zod.

Wonder if it would work to get rid of ctx.async and just handle all results from _parse() as potentially async (i.e. check whether the return value is a Promise. Currently there seems to be a lot of potentially unnecessary Promise wrapping just based on ctx.async

from zod.