cokert / firelist Goto Github PK

When you logout it should take you to the home screen. Instead it left me looking at the list I had when logged in.

Sharing with emails is case sensitive. If case isn't exact, the sharing fails. Filtering by email in users.service.ts needs to be case insensitive.

When it displays, it doesn't care about whether it will wind up off screen and stretches the page.

When reloading from a route, the browser cuts off the path of the URL so that just the domain is in the address bar. The nav bar shows but no other components are loaded. Reloading again causes the home component to be displayed.

If a list is shared with me, there's no distinction between it and lists I created. I can then share that list with others. This doesn't seem to be preferred behavior. And if it is, the original list creator needs to see who has access and be able to revoke it. Or maybe set a list permission level where anyone can share it or only the creator can share it.

The sharing mechanism doesn't check that a user has signed in before. It appears that sharing with a user that hasn't signed in yet actually does nothing in the DB, and doesn't alert the user that nothing happened. It needs to either alert that there were no users found matching that email, or have the email and shared list so that when they sign in they have the list available.

If you reload on these pages, you wind up with extra users in the who has access list. weird. I can see them being emitted through console.log statements as one group.