cohdjn / cisecurity Goto Github PK

hey,

one of the problems is the hiera.yaml

is: path: 'os/%{facts.os.name}%{facts.os.release.major}.yaml'

should be: path: 'os/%{facts.os.family}%{facts.os.release.major}.yaml'

the other issue is that facts.d/cisecurity relies on the subscription manager to be installed.

after this, is stopped testing.

Kind regards,

Line 376 of manifests/redhat7/services.pp refers to class ntpd which should be ntp.

root@puppet:/etc/puppetlabs/code/environments/devops_testing/modules# puppet module install cohdjn-cisecurity --version 0.7.1 --environment devops_testing
Notice: Preparing to install into /etc/puppetlabs/code/environments/devops_testing/modules ...
Notice: Downloading from https://forgeapi.puppet.com ...
Error: Could not install module 'cohdjn-cisecurity' (???)
No version of 'cohdjn-cisecurity' can satisfy all dependencies
Use puppet module install --ignore-dependencies to install only this module

The module is only compatible with puppet >= 4.7.0 < 5.0.0 but the only available versions of puppet I can find in any yum repository is 3.x (epel repo) or 5.x (puppet labs repo).

Looking at the code I can see it's clearly not compatible with 3.x so I installed puppet 5.3.3 to give it a try. The following is the output when following the installation instructions from the forge.

puppet module install cohdjn-cisecurity --version 0.6.5
Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ...
Notice: Downloading from https://forgeapi.puppet.com ...
Error: Could not install module 'cohdjn-cisecurity' (???)
  No version of 'cohdjn-cisecurity' can satisfy all dependencies
    Use `puppet module install --ignore-dependencies` to install only this module

Any ETA on when this can be puppet 5 compatible?

I have tried several possibilities to specify two or more users for the sshd_allowed_users parameter in RedHat7.yaml.
For example:
cisecurity::redhat7::services::sshd_allowed_users:
- 'user1'
- 'user2'
Or:
cisecurity::redhat7::services::sshd_allowed_users: ['user1', 'user2']

But each time I get this error:

Notice: /Stage[main]/Cisecurity::Redhat7::Services/Sshd_config[AllowUsers]/value: value changed ['user1'] to 'user1 user2'
Debug: Puppet::Type::Sshd_config::ProviderAugeas: Save failure details:
/augeas/files/etc/ssh/sshd_config/error/path = /files/etc/ssh/sshd_config/AllowUsers
/augeas/files/etc/ssh/sshd_config/error/lens = /opt/puppetlabs/puppet/share/augeas/lenses/dist/sshd.aug:84.7-.46:
/augeas/files/etc/ssh/sshd_config/error/message = Failed to match

{ /[0123456789]+/ = /[^\001-\004\t\n ]+/ }*
with tree
{ "1" = "user1 user2" }
Error: /Stage[main]/Cisecurity::Redhat7::Services/Sshd_config[AllowUsers]: Could not evaluate: Failed to save Augeas tree to file. See debug logs for details.

If have tested with only augeasproviders_ssh and there is no problem specifying more users.
What am I doing wrong?

puppet --version
4.10.9