codylico / reedkiln Goto Github PK

Support %s,%a,%p,%x,%%, and %i where snprintf is unavailable.

The following line fails to compile on Ubuntu 22.04.

Likely the reedkiln_log_swap++ should say reedkiln_log_index++.

The current macro does not allow for automatic conversion of its argument to Boolean. As a result, the following fails:

class Truthy {
  explicit operator bool() { return true; }
};

int test(void* ) {
  Truthy fact;
  std::ostringstream buffer;
  std::unique_ptr<int> ptr(new int(5));
  int *eight_nums = (int*)malloc(sizeof(int) * 8);

  reedkiln_assert(fact);
  reedkiln_assert(buffer);
  reedkiln_assert(ptr);
  reedkiln_assert(eight_nums);
  return Reedkiln_OK;
}

If possible, reedkiln_assert should provide a way to automatically convert its argument to Boolean.

If the buffer is shared among threads, there needs to be some form of synchronization.

Maybe an atomic counter is enough?