Hi,

I went back to working with my multivideo project and I tried the new build.

Just a couple of things I had to change in order to make it work, that maybe you want to check/update:

• public constructor for EventHandler

• In the LibVLC class I had to change the constructor to

  public LibVLC() {
  mAout = new AudioOutput();
  sInstance = this;
  }

Because without sInstance set it would display anything on the surface.

Thanks.

Hi, thanks for this awesome patch in the first place.

Wouldn't it be good to include a sample example activity with 2 players working at the same time?

I tried to implement the patches in this sample vlc example app

https://bitbucket.org/edwardcw/libvlc-android-sample

But I get both videos blinking at the same time during the playback (I'll keep working on this and post the sample myself if I can fix it)

I checked out to the vlc android commit with hash 'b13ca4573d9f1a7ad5818334261cc6a0e1be7108' and applied the patch "0001-Support-multiple-video-player-instances.patch". It ran successfully.

Then I did 'cd vlc/' , and applied the patch '0001-Support-for-multiple-video-instances.patch'. I am getting error while applying this patch.

Error Log:

Checking patch include/vlc/libvlc_media_player.h...
Checking patch lib/media_player.c...
Hunk #1 succeeded at 515 (offset -3 lines).
Hunk #2 succeeded at 1020 (offset -4 lines).
Checking patch modules/video_output/android/nativewindow.c...
error: while searching for:

include "utils.h"

extern JavaVM *myVm;
extern jobject jni_LockAndGetAndroidJavaSurface();
extern void jni_UnlockAndroidSurface();
extern void jni_SetAndroidSurfaceSize(int width, int height, int visible_width, int visible_height, int sar_num, int sar_den);

static int Open(vout_window_t *, const vout_window_cfg_t *);
static void Close(vout_window_t *);

error: patch failed: modules/video_output/android/nativewindow.c:38
error: modules/video_output/android/nativewindow.c: patch does not apply
Checking patch modules/video_output/android/surface.c...
error: while searching for:
*****************************************************************************/

extern JavaVM *myVm;
extern void *jni_LockAndGetAndroidSurface();
extern jobject jni_LockAndGetAndroidJavaSurface();
extern void jni_UnlockAndroidSurface();
extern void jni_SetAndroidSurfaceSize(int width, int height, int visible_width, int visible_height, int sar_num, int sar_den);

// _ZN7android7Surface4lockEPNS0_11SurfaceInfoEb
typedef void (*Surface_lock)(void *, void *, int);

error: patch failed: modules/video_output/android/surface.c:74
error: modules/video_output/android/surface.c: patch does not apply
Checking patch modules/video_output/android/utils.h...
Checking patch src/libvlc.c...

Please guide me on how to resolve this issue.