codemonkey-jack / shoestrap-3 Goto Github PK

Notice: Theme without header.php is deprecated since version 3.0 with no alternative available. Please include a header.php template in your theme.

Theme without footer.php is deprecated since version 3.0 with no alternative available. Please include a footer.php template in your theme.

Believe this is replicated by doing get_header()

(Rose this issue on roots as well)

Found this: https://gist.github.com/4184476
perhaps this should be added in the theme? Opinions?

parse error: failed at @textColor: ; C:\wamp\www\mgateswp/wp-content/themes/shoestrap-master//assets/css/../less/variables.less on line 36

Etc

Should maybe be replaced with ''; instead of just ;

@sansFontFamily:        ;
@serifFontFamily:       ;
@monoFontFamily:        ;

Shoestrap increases load time on every single page by at least 3 seconds, regardless if I'm logged in as admin (to view the customizer) or not.

If I switch my theme to Roots or TwentyEleven, site speed is normal at 0.3ms.

The default colors should be something pretty and not almost random.

This breaks the customizer (webfonts not showing up / etc)

/*

• Reset cache when in customizer
  */
  function shoestrap_login_scripts_cache_reset() {
  delete_transient( 'shoestrap_login_scripts' );
  shoestrap_login_scripts_cache();
  }
  add_action( 'customize_preview_init', 'shoestrap_buttons_css_cache_reset' );

line 243 should be: add_action( 'customize_preview_init', 'shoestrap_login_scripts_cache_reset' );

[02-Dec-2012 14:36:33 UTC] PHP Warning: Division by zero in C:\wamp\www\mgateswp\wp-content\themes\shoestrap-master\lib\customizer\custom-builder\custom-builder.php on line 482

[02-Dec-2012 14:36:33 UTC] PHP Stack trace:

[02-Dec-2012 14:36:33 UTC] PHP 1. {main}() C:\wamp\www\mgateswp\index.php:0

[02-Dec-2012 14:36:33 UTC] PHP 2. require() C:\wamp\www\mgateswp\index.php:17

[02-Dec-2012 14:36:33 UTC] PHP 3. require_once() C:\wamp\www\mgateswp\wp-blog-header.php:12

[02-Dec-2012 14:36:33 UTC] PHP 4. require_once() C:\wamp\www\mgateswp\wp-load.php:29

[02-Dec-2012 14:36:33 UTC] PHP 5. require_once() C:\wamp\www\mgateswp\wp-config.php:95

[02-Dec-2012 14:36:33 UTC] PHP 6. do_action() C:\wamp\www\mgateswp\wp-settings.php:323

[02-Dec-2012 14:36:33 UTC] PHP 7. call_user_func_array() C:\wamp\www\mgateswp\wp-includes\plugin.php:403

[02-Dec-2012 14:36:33 UTC] PHP 8. WP_Customize_Manager->wp_loaded() C:\wamp\www\mgateswp\wp-includes\plugin.php:403

[02-Dec-2012 14:36:33 UTC] PHP 9. WP_Customize_Manager->customize_preview_init() C:\wamp\www\mgateswp\wp-includes\class-wp-customize-manager.php:272

[02-Dec-2012 14:36:33 UTC] PHP 10. do_action() C:\wamp\www\mgateswp\wp-includes\class-wp-customize-manager.php:328

[02-Dec-2012 14:36:33 UTC] PHP 11. call_user_func_array() C:\wamp\www\mgateswp\wp-includes\plugin.php:403

[02-Dec-2012 14:36:33 UTC] PHP 12. shoestrap_custom_builder_rewrite_variables() C:\wamp\www\mgateswp\wp-includes\plugin.php:403

/*

• Reset cache when in customizer
  */
  function shoestrap_typography_css_cache_reset() {
  delete_transient( 'shoestrap_typography_css' );
  shoestrap_typography_webfont_cache();
  }
  add_action( 'customize_preview_init', 'shoestrap_typography_webfont_cache_reset' );

add action should be: "shoestrap_typography_css_cache_reset"

Details on Affix: http://twitter.github.com/bootstrap/javascript.html#affix

It seems that when we're scaling down our window, the content of the secondary navbar overlaps main page content.

When the user selects "NavBar" as branding mode on the customizer, the logo is resized and placed in the NavBar. However, the resizing of the logo is done using CSS,
It should be done using WordPress's API instead.

If we don't save and close, the live preview is not refreshed abd we can't see the actual changes

The problem is that the url contains a ':' that wp_enqueue_script turns to %3A

whenever the secondary navigation bar is fixed:top, a dropdown in menu doesn't drop

since commit aristath/shoestrap@d3813c8

When editing the customizer settings, if we change the "background color" setting, the preview is only updated for the body.custom-background element, and not on the div#wrap element.
If however we change another setting afterwards, we can see it change.

URLS should be sanitized and verified to prevents things like entering @username instead of http://twitter.com/username

Example:

$wp_customize->get_setting('blogname')->transport='postMessage';
$wp_customize->get_setting('blogdescription')->transport='postMessage';

This should provide users the option to enter their own custom CSS.

It will be useful, especially on mutisite installations where users don't have access to many things.

Currently it's auto generated by navbar.php based on the navbar color. Sometimes this causes odd results

Browser feedback
Failed to load resource: the server responded with a status of 404 (Not Found)
<script type='text/javascript' src='/strapi/lib/customizer/sharrre/jquery.sharrre.min.js'></script>

It seems like get_stylesheet_directory_uri() in /wp-content/themes/shoestrap/lib/customizer/functions/social.php is not working

Comment buttons colors are not always applied.