codelicia / turbo-enigma Goto Github PK

level=warning msg="[runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive."

For instance:
provider/slack.go:SendPullRequestEvent(URL, title, author string) error

The release version must be respected.

https://golangbyexample.com/go-mod-tidy/

We can use helm test for it and my be a good idea to use k3d on test pipeline to run it.

We have to check the release process. The latest changes merged to master were not available on Docker Hub.

#34 (comment)

Is this a good moment to change those labels to something more structured, like this https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ ?

So these labels could become app.kubernetes.io/name: turbo-enigma or event app.kubernetes.io/name: {{ $.Chart.Name }}

Original message here #28 (comment)

We could have a feature to react to the notification message depending on the status of the merge request:

⛏️ draft merge request
⚙️ pipeline running
❌ pipeline failed
🟢 pipeline is ok
💬 has threads to be resolved
✅ merge request approved
🚀 merged

provider/slack.go

func (s *Slack) NotifyMergeRequestCreated(mergeRequest model.MergeRequestInfo) error
func (s *Slack) sendMessage(message []byte) error

The new PRs, like this one, are complaining about the introduction package.

Sometimes, turbo enigma will react to messages containing partial content. For example, if the posted message contains the MR URL, it will find and react to other messages containing the MR URL.

Can be usefull to have a deploy option using Ingress instead of node port.
It's a bit more expensive on Cloud providers but is the right an elegant solution. 😸

On handlers.go, we have some hardcoded configurations that should be replaced by the equivalent env vars. The username and avatar strings should be replaced with the dynamic values.

var formating = fmt.Sprintf(
    template,
    os.Getenv("MESSAGE"),
    html.EscapeString(mr.ObjectAttributes.URL),
    html.EscapeString(mr.ObjectAttributes.Title),
    html.EscapeString(mr.User.Name),
    "https://avatars.githubusercontent.com/u/46966179?s=200&v=4",
    "codelicia/turbo-enigma",
)

Looking at the Slack Token Types we are currently using some methods to search and react to merge request notifications available just for User Tokens.

As a side effect, the reaction is done by the Slack user who created the token, not by the integration. It can cause confusion among people not aware of the integration.

A possible solution is to review the Slack Provider to use just API methods available for bots.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository