codecorico / allons-y Goto Github PK

As a developer contributor I want to work on a final plateform feature like a package (eg. Docker)

Technical criteria:

• Rethink of the features by packaging the final install files

. Fix every "Plateform" wording by "Platform"
. typo error in wizard message: '"It's your firstime on the PediaUI plateform"
. typo in gulpfile.js: The spelling of environment is not correct. Should have only one "n" - "Your environnement is not configured"

I'm submitting a...

[ ] bug report
[x] feature request

Current behavior
DependencyInjection is a global variable.

Expected behavior
DependencyInjection should be an injection, like $dependencyInjection

What is the motivation / use case for changing the behavior?
To avoid globals

What are the allons-y modules are you using?
allons-y 1.0.3

As a developer contributor I want to restart node server automatically instead of restart the node server manually after every change to make it work

Node module that i think to use:

• nodemon
• forever
• node-supervisor

Whenever a route file is modified, it's not regenerated under the public directory

HTR

1. Edit a route-file under your feature directory (For instance my-feature-route.js)
2. Wait a few seconds
3. Go to your feature public directory /public/my-feature/
4. Edit the file /public/my-feature/my-feature-route.js

Result

• The modifications (step 1 of HTR are not taken into account). You need to stop and restart the gulp task

Expected

• You must see your changes after a few seconds without the need of restarting the gulp task

Leads

It seems that the gulpfile responsible for routes (common-routes-gulpfile.js), does not delete the require cached.
The following line needs to be added delete require.cache[require.resolve(file)]; before requiring the line routesConfig = require(file),

Prerequisites

In order to reproduce the bug you have to use a Linux os.
You have also to make sure that you play the following commands as a root user

HTR

• Play

  npm install -g allons-y

• Launch the program from your bash shell

  allons-y

Result

The following error message appears

No such file or directory

Expected

We should have the default output of allons-y

  Usage: allons-y [options]

  Options:

    -h, --help     output usage information
    -v, --version  output the version number
    -f, --force    Force the creation/update of the plateform
    -n, --no-npm   Create/update the plateform without use npm
    init           Create an Allons-y! plateform
    update         Update a Allons-y! plateform
    env            Configure your plateform environment

Leads

If you play this command,

# Make sure that you play it as root
dos2unix /usr/local/lib/node_modules/allons-y/features/cli/cli
```,
the bug no more appears.
So it seems to be a line format issue (*CRLF*) : npm publisher does not seem to convert this characters like git does.

How To Reproduce

• I create a new plateform with allons-y init
• I set my env with allons-y env and I set a Mongo database named "Master" on it
• In my code, i write $MongoMaster to use the database
• I push this project on a git repository
• A other team member clone the repo and set its env with allons-y env
• 💥 It doesn't know the name of the database(s) entered.

Env variables have to be parameters and not code logics

I'm submitting a... (check one with "x")

[x] bug report
[ ] feature request

Current behavior
The Live command exit doesn't works on Linux.
The command npm stop doesn't stop the processes too.

Expected behavior
When I call one of these commands, it would stop the Allons-y processes

Minimal reproduction of the problem with instructions

• Start your allons-y with npm start.
• Wait for the processes to start.
• Execute the Live command exit
• 💥 Allons-y is stopped but its children processus don't.

What are the allons-y-* modules are you using?
allons-y 1.0.1

Browser/Server:
Ubuntu 14.04.5 LTS

Node: node --version = 6.5.0

Prerequisites

Make sure that you have read guidelines for contributing and correctly installed allons-y

HTR

• Play

  mkdir ~/my_test

• Launch allons-init on your test directory

  allons-y init 

• Set the option
  Use Plumes #quality version? to yes.

Result

The following error message appears

Error: ENOENT, no such file or directory '/home/sgs/temp/node_modules/plumes/features/common/less/common-mixins.less'
    at Error (native)
    at Object.fs.statSync (evalmachine.<anonymous>:797:18)
    at Object.copySync (/home/sgs/allons-y/allons-y/node_modules/fs-extra/lib/copy.js:74:58)
    at Object.utils.copy (/home/sgs/allons-y/allons-y/features/cli/cli-utils.js:77:8)
    at Object.afterInstall (/home/sgs/allons-y/allons-y/features/views/views-cli.js:58:11)
    at /home/sgs/allons-y/allons-y/features/cli/cli:215:18
    at /home/sgs/allons-y/allons-y/node_modules/async/lib/async.js:246:17
    at iterate (/home/sgs/allons-y/allons-y/node_modules/async/lib/async.js:146:13)
    at /home/sgs/allons-y/allons-y/node_modules/async/lib/async.js:157:25
    at /home/sgs/allons-y/allons-y/node_modules/async/lib/async.js:248:21

Expected

We should have no message error and the installation must go to the end.

As a developer contributor I want to connect my plateform to my MySQL database

Technical criteria:

• Create the MySQL Connector
• Ask the user to know which databases to use with allons-y env

As a plateform developer I want to use the last version of Plumes (https://github.com/CodeCorico/plumes)

A discussion must be done on this subject.

For now, underscore is used to declare private variables.

However, this has no effect and is just a convention.
If we want privacy we must implement it as javascript offers many ways to do it.

The underscore does not implements privacy.
A good argument is given by Douglas Crockford:
http://javascript.crockford.com/code.html#names
hhttp://javascript.crockford.com/private.html

Angular does not seem to use this pattern.
Neither does React.

How to reproduce:

• I create a new plateform with allons-y init
• 💥 In the folder versions/0.1 I get the file version-0.0.1.js instead of version-0.1.0.js

How to reproduce

• I start the plateform instance with npm start
• I start a second plateform instance with npm start
• 💥 The first instance isn't killed so the new second instance try to restart itself in an inifinte loop.

For now, try/catch mechanism is not enough used in allons-y.

It could be used in order to deal with :

• Database errors
• io/errors
• network errors
• etc ...

How to reproduce

• I start the server
• I kill a feature
• I restart the server
• 💥 the feature is still active

A feature is builded in the /public/ directory but never cleaned if it is deleted.