codecommission / subscriptions-transport-sse Goto Github PK

@MikeBild Could you please add a something like "Server-Sent Events vs. WebSockets (pros and cons)" section to the README.md?

Since this transport plugin has been last updated 2 years ago, I'm wondering if this is a feasable solution for a websocket-alternative.

https://subkit-subscriptions-server.cloud.dropstack.run/graphql and https://subkit-subscriptions-app.cloud.dropstack.run don't work. @MikeBild PTAL.

1. It leaks, because of the keepalive setInterval never being cancelled on socket close
2. Why is the keepalive needed?
3. Why do you close the subscription when the socket closes? When the browser reconnects, the subscription won't exist any more
4. Perhaps the client should send a random token and that gets used for all subsequent connections, so that multiple subscription calls all happen on the same SSE stream
5. Perhaps the subscribed queries should be stored with that client token, and then unsub all on connection drop + re-subscribe when the connection is re-established
6. Or maybe the client needs to store all active queries, and when the SSE drops close it, and re-subscribe all

According to https://github.com/apollographql/graphql-subscriptions, the SubscriptionManager is deprecated.

It seems like subscriptions-transport-sse will not work without SubscriptionManager.

Is there any way to use subscriptions-transport-sse with the current version of Apollo's GraphQL subscriptions without SubscriptionManager?

Could you provide an example how to use this library with apollo 2.0?
I guess that it's not supported because the networkInterface parameter was removed in version 2. If so, do you plan to make it compatible in the future?

Thanks