Giter Club home page Giter Club logo

extract's People

Contributors

cmaglie avatar craig65535 avatar josephwoodward avatar matteosuppo avatar tmm1 avatar umbynos avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

extract's Issues

heavy memory usage when extracting large zip file

instead of read the whole body into a buffer, can we try zipstream like java ZipInputStream?

github.com/xenking/zipstream

        zr := zipstream.NewReader(&zipFile)
	meta, err := zr.Next()
	if err != nil {
		if err != io.EOF {
			panic(err)
		}
	}
	log.Printf("file name: %s", meta.Name)
	compressedFile, err := ioutil.ReadAll(zr)
	if err != nil {
		panic(err)
	}
	log.Printf("file content: %s", string(compressedFile[:]))

heavy memory usage when extracting large tar.gz

extract/extractor.go

Lines 143 to 148 in cb78af9

case tar.TypeReg, tar.TypeRegA:
var data bytes.Buffer
if _, err := copyCancel(ctx, &data, tr); err != nil {
return errors.Annotatef(err, "Read contents of file %s", path)
}
files = append(files, file{Path: path, Mode: info.Mode(), Data: data})

extract/extractor.go

Lines 162 to 167 in cb78af9

// Now we make another pass creating the files and links
for i := range files {
if err := e.copy(ctx, files[i].Path, files[i].Mode, &files[i].Data); err != nil {
return errors.Annotatef(err, "Create file %s", files[i].Path)
}
}

It looks like the data from the tar archive is copied into memory instead of being extracted to the filesystem directly. This causes a lot of memory usage and makes extract unusable on low-memory devices.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.