Giter Club home page Giter Club logo

Comments (9)

alanag13 avatar alanag13 commented on July 30, 2024

This all seems like super useful functionality that I think we can safely say we would be happy to include, but I think this should probably be broken up into smaller enhancements -- otherwise this would be a monstrous PR.

from code42cli.

ceciliastevens avatar ceciliastevens commented on July 30, 2024

Yeah, that makes sense. Is there any particular way you'd prefer to have it broken up?

The one that seems clearest to me should be separate would be "list licensed users", as that's currently a standalone script and isn't especially straightforward.

from code42cli.

alanag13 avatar alanag13 commented on July 30, 2024

I'd probably break it up like:

  • non-license modifications to the list command
  • licensed users
  • bulk block / deactivate (should include unblock / reactivate, and non-bulk versions of these commands)
  • bulk change username / org (include non-bulk versions of these commands)

from code42cli.

alanag13 avatar alanag13 commented on July 30, 2024

the smaller the better (I wouldn't be upset about a PR that did just block/unblock, for example), but the above is probably the largest each PR should reasonably be, imo.

from code42cli.

ceciliastevens avatar ceciliastevens commented on July 30, 2024

That makes sense. Should I file separate issues, or can we have multiple PRs all pointing back to (but not closing) this issue?

from code42cli.

ceciliastevens avatar ceciliastevens commented on July 30, 2024

I know @maddie-vargo plans to work on this as well, time permitting.

from code42cli.

alanag13 avatar alanag13 commented on July 30, 2024

Keeping this one open is fine. Thanks as usual for contributing, looking forward to it!

from code42cli.

maddie-vargo avatar maddie-vargo commented on July 30, 2024

I would like to suggest adding user-based legal hold membership to the list here, similar to how the devices list --include-legal-hold-membership command appends membership info for all results of the query.

Currently, the legal-hold command only reports on users on one specified legal hold. This is a gap called out in Issue #176

from code42cli.

timabrmsn avatar timabrmsn commented on July 30, 2024

The only remaining items on the summary list is the license status of users, and block/unblock commands. We have a ticket for adding block/unblock on the backlog so that will eventually make it in.

And the license report is now it's own separate issue: #266

from code42cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.