The bs-react-stripe-elements from cnguy

bs-react-stripe-elements's People

Contributors

Stargazers

Watchers

bs-react-stripe-elements's Issues

Style Props

Current way of passing style props to components is dependent on [@bs.deriving abstract] auto-generated code which is kinda messy and bad for developer UX.

          <PaymentRequestButtonElement
            paymentRequest={self.state.paymentRequest}
            className="PaymentRequestButton"
            style={
              StripeElements.PaymentRequestButtonElement.makeStyle(
                ~paymentRequestButton=
                  StripeElements.PaymentRequestButtonElement.makePaymentRequestButton(
                    ~theme="dark",
                    ~height="64px",
                    ~type_="donate",
                    (),
                  ),
                (),
              )
            }
          />

Something like this instead would probably be a lot better:

          <PaymentRequestButtonElement
            paymentRequest={self.state.paymentRequest}
            className="PaymentRequestButton"
            theme="dark"
            height="64px"
            type_="donate"
          />

We could even constrain the types so that it becomes like so:

        PaymentRequestButtonElement.(
          <PaymentRequestButtonElement
            paymentRequest={self.state.paymentRequest}
            className="PaymentRequestButton"
            theme=Dark
            height="64px"
            type_=Donate
          />
        )

Recommend Projects