cmtt / gulp-di Goto Github PK

View Code? Open in Web Editor NEW

41.0 3.0 1.0 521 KB

gulp-di is a dependency injection framework for the Gulp streaming build system.

JavaScript 100.00%

javascript gulp-plugins dependency-injection javascript-dependency-injection

gulp-di's People

Contributors

Stargazers

Watchers

Forkers

skitto0307

gulp-di's Issues

Expose gulp-util in DI contexts

As gulp-util is always a dependency of Gulp, it might be included in gulp-di's scope.
This would allow its users to access CLI parameters among other useful methods

tweaks

contrib/help.js#L65-L70 it's always object and why lib/di.js#L283-L284 is needed?

Does not parse ES2015 functions properly

Please see this issue:

Gulp can be used in conjunction with ES2015 code in two ways:

Writing ES2015+ code - the "gulpfile.js" would be written in ES2015+, as Node.js supports already a subset of the new standard.

Writing ES2015+ code using the "Babel" transpiler - the "gulpfile.babel.js" and all imported modules would be transpiled back to ES5 code. In this case, parse-function would work as intended.

It would be also possible to make use of a JavaScript parser like esprima or acorn.

Doc example show di instance with params in wrong order

Ie the api example is:

GulpDI(object gulp, object options)

The code example is:

let di = GulpDI({
  DEBUG: false, // when set to true, the plugin will log info to console. Useful for bug reporting and issue debugging
  pattern: ['gulp-*', 'gulp.*'], // the glob(s) to search for
  config: 'package.json', // where to find the plugins, by default searched up from process.cwd()
  scope: ['dependencies', 'devDependencies', 'peerDependencies'], // which keys in the config to look within
  replaceString: /^gulp(-|\.)/, // what to remove from the name of the module when adding it to the context
  rename: {}, // a mapping of plugins to rename
  renameFn: function (name) { ... } // a function to handle the renaming of plugins (the default works)
}, require('gulp'));

Subsequently the error for putting them in the wrong order doesn't make it very obvious. :)

$ gulp
/home/adam/Programming/work/salespreso-gulp-v2/node_modules/gulp-di/contrib/help.js:104
    return _task.apply(gulp, args);
                ^

TypeError: Cannot read property 'apply' of undefined
    at Object.HelpTask.gulp.task (/home/adam/Programming/work/salespreso-gulp-v2/node_modules/gulp-di/contrib/help.js:104:17)
    at GulpDI.HelpTask (/home/adam/Programming/work/salespreso-gulp-v2/node_modules/gulp-di/contrib/help.js:109:8)
    at GulpDI.$injector (/home/adam/Programming/work/salespreso-gulp-v2/node_modules/gulp-di/lib/di.js:56:20)
    at GulpDI.inject (/home/adam/Programming/work/salespreso-gulp-v2/node_modules/gulp-di/lib/di.js:192:30)
    at GulpDI.parseOptions (/home/adam/Programming/work/salespreso-gulp-v2/node_modules/gulp-di/lib/di.js:161:14)
    at new GulpDI (/home/adam/Programming/work/salespreso-gulp-v2/node_modules/gulp-di/lib/di.js:118:12)
    at /home/adam/Programming/work/salespreso-gulp-v2/node_modules/gulp-di/lib/di.js:330:12
    at module.exports (/home/adam/Programming/work/salespreso-gulp-v2/index.js:6:14)
    at Object.<anonymous> (/home/adam/Programming/work/salespreso-gulp-v2/examples/jspm/gulpfile.js:4:1)
    at Module._compile (module.js:413:34)

Don't work whith gulp 4

node -v
v6.5.0

{
  "name": "gulpdi-test",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "gulp": "gulp"
  },
  "devDependencies": {
    "babel-preset-es2015": "^6.18.0",
    "babel-register": "^6.18.0",
    "del": "^2.2.2",
    "gulp": "github:gulpjs/gulp#4.0",
    "gulp-debug": "^2.1.2",
    "gulp-di": "0.0.33",
    "gulp-sass": "^2.3.2",
    "make-targs": "github:pvlv/make-targs#v1.0.0",
    "run-sequence": "^1.2.2"
  }
}

// /tasks/styles.js

'use strict';

module.exports = (gulp, sass) => {
  gulp.task('styles', () => {
    return gulp.src('./fixtures/styles/*.scss')
      .pipe(sass())
      .pipe(gulp.dest('./results/css/'));
  })
}

// /tasks/default.js

'use strict';

module.exports = function (gulp) {
  gulp.task('default', gulp.parallel(
      'styles'
  ));
}

// /gulpfile.js

const gulp = require('gulp');

const di = require('gulp-di')(gulp, {
  pattern: ['gulp-*', 'gulp.*']
});

di
  .tasks('./tasks')
  .resolve();

module.exports = gulp;

Stack trace

assert.js:85
  throw new assert.AssertionError({
  ^
AssertionError: Task never defined: styles
    at getFunction (/data/node_modules/undertaker/lib/helpers/normalizeArgs.js:15:5)
    at arrayMap (/data/node_modules/lodash.map/index.js:140:21)
    at map (/data/node_modules/lodash.map/index.js:1836:10)
    at normalizeArgs (/data/node_modules/undertaker/lib/helpers/normalizeArgs.js:19:10)
    at Gulp.parallel (/data/node_modules/undertaker/lib/parallel.js:13:14)
    at GulpDI.module.exports (/data/tasks/default.js:4:29)
    at GulpDI.resolve (/data/node_modules/gulp-di/lib/di.js:261:34)
    at Object.<anonymous> (/data/gulpfile.js:10:4)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)

If install gulp 3.8.1 - gulp-di work correctly

Add an accessor to an array of currently-running Gulp tasks

.byId should not return unresolved modules

When .byId() is used to access a module before .resolve() was called, the entire dependency injection notation will be returned. This should be avoided by throwing an error.

(In contrast, .byId can be called to access constants which were declared beforehand. This behavior allows to use .inject() calls, f.e. for configuration.)

cmtt / gulp-di Goto Github PK

gulp-di's People

Contributors

Stargazers

Watchers

Forkers

gulp-di's Issues

Expose gulp-util in DI contexts

tweaks

Does not parse ES2015 functions properly

Doc example show di instance with params in wrong order

Don't work whith gulp 4

Add an accessor to an array of currently-running Gulp tasks

.byId should not return unresolved modules

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent