Comments (5)
The convention is that a transformation is always a post multiplication.
Meaning if you have a transformation q0 followed by q1, then the combined transformation will be q1*q0.
It seems to me that that's what scipy is doing, right?
I don't even understand how it would work correctly if it was otherwise, actually, but i seem to remember that at some point i changed the quaternion multiplication to post multiplication in one of the functions because it was giving the wrong result
from optas.
Here I changed this line a while back to a pre multiplication.
That's what it should be in my perspective:
Line 812 in 3eeeaf3
Indeed, i notice that for the homogeneous transformations you are using a post multiplication like so:
Line 713 in 3eeeaf3
I don't know who that would work, but i also haven't tested it.
from optas.
I guess what ever convention I started with a got working is what I stuck with - I am happy to stick with what we have for now if it's not causing an issue. Happy to close this issue? Can re-open if this becomes a problem.
from optas.
Yeah, my feeling is that we will eventually have to look into it.
But we can reopen it once we ran into problems.
from optas.
Sounds good, closing for now.
from optas.
Related Issues (20)
- Support Euler angles rather than only RPY in RobotModel HOT 1
- Documentation builds incorrectly HOT 1
- Visualizer and draw_sphere are missing HOT 3
- Add unit test that runs example.py HOT 1
- SyntaxError: invalid syntax during Run tests after the installation HOT 4
- Deprecate spatialmath.py HOT 1
- Missing Matplotlib in deps
- Issue with visualizer HOT 4
- Fix instructions for installing from source
- Add safe percentage (or similar) in enforce_model_limits
- OSQP did_solve fails
- For two-arm robot, there happens incorrect geometric and analytical Jacobians HOT 5
- Add unit test for dual arm robot.
- Installation - sudo pip install . HOT 3
- Support for additional robot description formats
- Consider re-vamping visualizer
- Remove git rebase leftover
- Some functions need deprecating
- get_link_position_function() happens problem for mobile dual-arm robot
- `optas.Visualize.sphere` throwing TypeError in Python 3.12 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from optas.