Giter Club home page Giter Club logo

Comments (5)

joaomoura24 avatar joaomoura24 commented on June 14, 2024

The convention is that a transformation is always a post multiplication.
Meaning if you have a transformation q0 followed by q1, then the combined transformation will be q1*q0.
It seems to me that that's what scipy is doing, right?

I don't even understand how it would work correctly if it was otherwise, actually, but i seem to remember that at some point i changed the quaternion multiplication to post multiplication in one of the functions because it was giving the wrong result

from optas.

joaomoura24 avatar joaomoura24 commented on June 14, 2024

Here I changed this line a while back to a pre multiplication.
That's what it should be in my perspective:

quat = Quaternion.fromrpy(rpy) * quat

Indeed, i notice that for the homogeneous transformations you are using a post multiplication like so:

T = T @ rt2tr(rpy2r(rpy), xyz)

I don't know who that would work, but i also haven't tested it.

from optas.

cmower avatar cmower commented on June 14, 2024

I guess what ever convention I started with a got working is what I stuck with - I am happy to stick with what we have for now if it's not causing an issue. Happy to close this issue? Can re-open if this becomes a problem.

from optas.

joaomoura24 avatar joaomoura24 commented on June 14, 2024

Yeah, my feeling is that we will eventually have to look into it.
But we can reopen it once we ran into problems.

from optas.

cmower avatar cmower commented on June 14, 2024

Sounds good, closing for now.

from optas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.