cmdrkeene / aws4 Goto Github PK

We are missing the extra service param in AWS4::Signer#sign:

class Signer
  RFC8601BASIC = "%Y%m%dT%H%M%SZ"
  attr_reader :access_key, :secret_key, :region
  attr_reader :date, :method, :uri, :headers, :body, :service

  def initialize(config)
    @access_key = config[:access_key] || config["access_key"]
    @secret_key = config[:secret_key] || config["secret_key"]
    @region = config[:region] || config["region"]
  end

  def sign(method, uri, headers, body, debug = false)
    @method = method.upcase
    @uri = uri
    @headers = headers
    @body = body
    @service = @uri.host.split(".", 2)[0]
    date_header = headers["Date"] || headers["DATE"] || headers["date"]
    @date = (date_header ? Time.parse(date_header) : Time.now).utc.strftime(RFC8601BASIC)
    dump if debug
    signed = headers.dup
    signed['Authorization'] = authorization(headers)
    signed
  end

Can we upload the latest copy of version 0.0.2?

Hi @cmdrkeene,

Are you planing on releasing soon? The current release (0.0.2) is from May 17th 2013 and does not include the PRs merged this year.

Thanks for working on the gem!

Deprecated call Digest::Digest, should be Digest::...
Thanks!

hello thank you for providing this code. i have a suggestion for an improvement based upon an issue i just encountered.

when given the following example URI:

https://host.whatever/procedures?start=1496880000000&end=1496966400000

the aws4 gem will make an invalid signature because, according to the AWS docs for generating canoncial requests:

Sort the parameter names by character code point in ascending order. For example, a parameter name that begins with the uppercase letter F precedes a parameter name that begins with a lowercase letter b.

so, when i change the above URI to the following:

https://host.whatever/procedures?end=1496966400000&start=1496880000000

the aws4 gem will make a valid signature, because the parameter names are ordered as shown in the documentation.

not sure when i can get around to submitting a pull request to fix this. regardless, i hope this will help someone else out there.

thanks.