cloudposse / terraform-aws-ses-lambda-forwarder Goto Github PK

Describe the Feature

Currently, this module tries to configure route53. It would be nice if I could use it with domains that are not controlled by AWS.

Expected Behavior

A clear and concise description of what you expected to happen.

Use Case

Domain is already configured outside of AWS. Leaving domain out of the config is not possible:

Error: Missing required argument

  on main.tf line 20, in module "ses_lambda_forwarder":
  20: module "ses_lambda_forwarder" {

The argument "domain" is required, but no definition was found.

Describe Ideal Solution

A clear and concise description of what you want to happen. If you don't know, that's okay.

Alternatives Considered

n/a

what

Suggested improvements: (can be implemented in separate PR)

• Build/package zip as part of CI to create an artifact
• Attach ZIP artifact to release
• Derive module version from git
• rename module to terraform-aws-ses-lambda-forwarder
• ensure S3 bucket uses encryption at rest (use https://github.com/cloudposse/terraform-aws-s3-log-storage for bucket creation)

why

• Artifacts should be built from CI/CD and not by developers
• Artifacts should not be committed to source control

tips

this appears to work to introspect the version of the current module:

variable "git_ref_type" {
  default = "tag"
}

data "external" "example" {
  count = "${var.git_ref_type == "tag" || var.git_ref_type == "branch" ? 1 : 0}"
  program = ["git", "-C", "${path.module}", "${var.git_ref_type}", "--points-at", "HEAD", "--format={\"ref\": \"%(refname:lstrip=2)\"}"]
}


output "ref" {
  value = "${join("", data.external.example.*.result.ref)}"
}

outputs:
ref = test-0.1.1

It fails if git_ref is not type "tag" or "branch"

what

• Add example invocation

why

• We need this so we can soon enable automated continuous integration testing of module

@osterman @goruha

Is this project still being maintained? It's been several months since Terraform 0.12.x release and this hasn't been updated yet. Any ETA? Looks like there is an existing PR for it

what

• Add a README.yaml

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

• WARN: Base branch does not exist - skipping

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update terraform cloudposse/module-artifact/external to v0.8.0 (main)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Hi,
I have use this project for learning aws and terraform. I have created a terraform.tfvars file and when I run terraform apply, I get the message

aws_ses_receipt_rule.default: expected s3_action.0.position to be at least (1), got 0

When I change ses.tf to read position = 1 instead of position = 0, I can apply. Is this a problem in the ses.tf file or is it my usage of it that is wrong?

Found a bug? Maybe our Slack Community can help.

Describe the Bug

Artifacts do not contain node_modules, thus lambda fails to execute with ImportError

Expected Behavior

Lambda functions properly and contains vendored dependencies.

Steps to Reproduce

Check the logs, notice that there are no node_modules being uploaded

https://github.com/cloudposse/terraform-aws-ses-lambda-forwarder/runs/823734871?check_suite_focus=true

When running the example hcl from the readme I'm getting the following error:

Error: failed to execute "curl": curl: (22) The requested URL returned error: 404
on .terraform/modules/ses_lambda_forwarder.artifact/main.tf line 1, in data "external" "curl":
1: data "external" "curl" {

It looks like there's a problem with the artifact url here:

The current provider version does not support comment as an attribute to the aws_route53_zone data resource. https://www.terraform.io/docs/providers/aws/d/route53_zone.html

Some solutions:

1. Remove the comment attr from the resource. This will always cause an error if there is a hosted zone with the same name in the same account.
2. Replace domain_name with hosted_zone_id
3. Lock provider version to when the provider supported it

Happy to make PR