Comments (10)
Should be "fixed" by de1553b.
The packaging script will now directly use the darwin package when doing a create-env
on OSX.
This change was actually needed because the generic compile scripts in the golang-release no longer reach out and use a different packaged based on the detected platform.
from bosh-vsphere-cpi-release.
After chatting with Palermo, maybe instead we should actually use the platform in the packaging script to select between the golang-1-darwin
package and the golang-1-linux
package for building isowrap9660
.
Updating the issue title and description accordingly.
from bosh-vsphere-cpi-release.
This issue was marked as Stale
because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale
label or comment below.
from bosh-vsphere-cpi-release.
Not stale.
from bosh-vsphere-cpi-release.
This issue was marked as Stale
because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale
label or comment below.
from bosh-vsphere-cpi-release.
Not stale.
from bosh-vsphere-cpi-release.
Well that's surprising. I was fully planning to just delete this package, because it's clearly not used by the packaging script here: https://github.com/cloudfoundry/bosh-vsphere-cpi-release/blob/master/packages/iso9660wrap/packaging#L4
But then I went and looked at what compile.env.generic
actually does, and it totally doesn't use the path the script is in, but uses the platform you are on to assume where the golang package will live!
https://github.com/bosh-packages/golang-release/blob/master/src/1/compile.env.generic
So even though it's calling the script inside of the golang-1-linux
package, it will setup the go environment for golang-1-darwin
🤯
This feels like a mistake in the bosh-packages scripts, but at the same time, it almost feels like a terrible feature. It makes the calling side look broken, but at the same time, now the calling side doesn't need to use uname
to figure out the platform and call the correct script?
from bosh-vsphere-cpi-release.
🤯 That is wild!
I inherently don't like that it prevents the caller from selecting the golang package they want to use.. but I also can't think of a situation where the caller wouldn't want to just use the correct script for their platform.
from bosh-vsphere-cpi-release.
This issue was marked as Stale
because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale
label or comment below.
from bosh-vsphere-cpi-release.
Not stale.
from bosh-vsphere-cpi-release.
Related Issues (20)
- BOSH Vsphere CPI APIs to automatically add diego cell or BOSH VM on which garden containers can be deployed on . HOT 1
- Failed to create multi-cluster configuration based on cloud-config azs HOT 2
- create_vm fails with postgres SQL error with CPI v72 HOT 6
- create_vm fails with postgres SQL error with CPI v72 HOT 9
- bump to ruby 3.1.x for upcoming jammy release HOT 2
- Migration from NSX-V to NSX-T HOT 2
- Bosh sometimes silently fails to add a vm to a group when using nsxt policy provider HOT 2
- TAS deployment failing - CPI error message 'Client 'admin' exceeded request rate of 100 per second' at Creating missing stage HOT 4
- Airgap compile (still) not working in v78 (release notes claim fixed in this release) HOT 2
- TAS deployment failure during network churn HOT 1
- effective_memory is possibly not the correct metric to check HOT 1
- Add config to apply tags to stemcells HOT 4
- Breaking change to NSX-T group lookup by ID instead of name with no fallback (?) HOT 8
- Unable to upload Jammy stemcell - "Permission to perform this operation was denied" HOT 2
- Support for vSphere 8 HOT 2
- Incorrect go platform binary used when compiling iso9660wrap HOT 2
- Offline deployment broken for v93 HOT 2
- Add opt-in support for per bosh deployment DRS rules HOT 3
- Is disk type=thin ignored for vsan in favor or vsan storage policy ? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bosh-vsphere-cpi-release.