cloudflare / hellogopher Goto Github PK

If you have GOBIN set in order to download executables via go get without the need to worry about GOPATH, this script downloads gvt to GOBIN rather than ./bin which creates an error for the setup process

Hello,
I try hellogopher with log15.

$ cd /tmp/

$ git clone https://github.com/inconshreveable/log15.git

$ cd log15

$ wget https://raw.githubusercontent.com/cloudflare/hellogopher/master/Makefile

$ vim Makefile # for setting the IMPORT_PATH like this: IMPORT_PATH := github.com/inconshreveable/log15

$ make setup
go get -u github.com/FiloSottile/gvt
./bin/gvt fetch golang.org/x/tools/cmd/goimports
2017/01/21 12:28:36 Fetching: golang.org/x/tools/cmd/goimports
2017/01/21 12:28:37 · Fetching recursive dependency: golang.org/x/tools/imports
2017/01/21 12:28:37 ·· Fetching recursive dependency: golang.org/x/tools/go/ast/astutil
./bin/gvt fetch github.com/wadey/gocovmerge
2017/01/21 12:28:37 Fetching: github.com/wadey/gocovmerge
2017/01/21 12:28:38 · Fetching recursive dependency: golang.org/x/tools/cover

$ make
.GOPATH/src/github.com/inconshreveable/log15/handler.go:11:2: cannot find package "github.com/go-stack/stack" in any of:
        /tmp/test/log15/.GOPATH/src/github.com/inconshreveable/log15/vendor/github.com/go-stack/stack (vendor tree)
        /usr/lib/go/src/github.com/go-stack/stack (from $GOROOT)
        /tmp/test/log15/.GOPATH/src/github.com/go-stack/stack (from $GOPATH)
.GOPATH/src/github.com/inconshreveable/log15/root.go:7:2: cannot find package "github.com/mattn/go-colorable" in any of:
        /tmp/test/log15/.GOPATH/src/github.com/inconshreveable/log15/vendor/github.com/mattn/go-colorable (vendor tree)
        /usr/lib/go/src/github.com/mattn/go-colorable (from $GOROOT)
        /tmp/test/log15/.GOPATH/src/github.com/mattn/go-colorable (from $GOPATH)

Do I miss something?
Thx in adv

Hi,

I've given hellogopher a try for an internal project at work to replace our own homegrown Makefile but I'm stumped on this error:

$ make test
go install errors: open /usr/local/go/pkg/darwin_amd64_race/errors.a: permission denied
go install internal/race: open /usr/local/go/pkg/darwin_amd64_race/internal/race.a: permission denied
go install encoding: open /usr/local/go/pkg/darwin_amd64_race/encoding.a: permission denied
go install unicode/utf16: open /usr/local/go/pkg/darwin_amd64_race/unicode/utf16.a: permission denied
go install unicode/utf8: open /usr/local/go/pkg/darwin_amd64_race/unicode/utf8.a: permission denied
go install crypto/subtle: open /usr/local/go/pkg/darwin_amd64_race/crypto/subtle.a: permission denied
go install crypto/internal/cipherhw: open /usr/local/go/pkg/darwin_amd64_race/crypto/internal/cipherhw.a: permission denied
go install internal/nettrace: open /usr/local/go/pkg/darwin_amd64_race/internal/nettrace.a: permission denied
go install container/list: open /usr/local/go/pkg/darwin_amd64_race/container/list.a: permission denied
go install vendor/golang_org/x/crypto/curve25519: open /usr/local/go/pkg/darwin_amd64_race/vendor/golang_org/x/crypto/curve25519.a: permission denied
go install unicode: open /usr/local/go/pkg/darwin_amd64_race/unicode.a: permission denied
go install math: open /usr/local/go/pkg/darwin_amd64_race/math.a: permission denied
make: *** [test] Error 1

I'm running:

$ go version
go version go1.8rc2 darwin/amd64

Any tips on where to look to try to get this working?

I experienced the make command only working correctly if go source file(s) is/are located in root folder of a repository.

make on lotharschulz/gohello02@tag/0.0.1 worked correctly only because of lotharschulz/gohello02@cc13b57

Hellogopher should detect the number of / and adjust the link target accordingly.

Try to be helpful for #1

Dep is now considered ready for production.

It would be awesome to switch Hellogopher to use this instead of gvt.

If I'm using hellogopher's Makefile in a project, it would be nice to be able to update the build system via the build system. If hellogopher changes after I've installed it, it should be simple (one command, if possible) to pull in the latest Makefile.

Ideas (in no particular order):

• Document using a git submodule for hellogopher. Drawbacks: requires a subdirectory, adds complexity, changes pretty much all of the usage, and submodules are also a little bit evil, so probably not a great idea.
• Have the setup target either automatically re-download, or check and prompts the user for redownload of, an updated Makefile. Drawbacks: setup now wants internet access, or may time out.
• Add a new target update-makefile or something that gets and overwrites (provided Git says there are no changes to) the updated Makefile. Drawbacks: has to be relatively git-aware. Should also probably move the old file to .old or similar.

Only github and one package for IMPORT_PATH?