cloudalchemy / ansible-process_exporter Goto Github PK
View Code? Open in Web Editor NEWProvision process exporter for prometheus monitoring tool
License: MIT License
Provision process exporter for prometheus monitoring tool
License: MIT License
What happened?
Running Ansible role fails when set to the latest release, in this case 0.2.0. Running without specified versions or with 'master' is successful, as new commits in master fix this. New release needs to be published to the repo, in order to reflect changes, e.g. 0.3.0.
Did you expect to see some different?
Playbook finishing.
How to reproduce it (as minimally and precisely as possible):
Running latest release, e.g.
- name: process_exporter
src: https://github.com/cloudalchemy/ansible-process_exporter.git
version: 0.2.0
Environment
0.2.0
ansible [core 2.11.0]
config file = None
configured module search path = ['/Users/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /opt/homebrew/Cellar/ansible/4.0.0/libexec/lib/python3.9/site-packages/ansible
ansible collection location = /Users/user/.ansible/collections:/usr/share/ansible/collections
executable location = /opt/homebrew/bin/ansible
python version = 3.9.5 (default, May 3 2021, 19:12:05) [Clang 12.0.5 (clang-1205.0.22.9)]
jinja version = 3.0.1
libyaml = True
TASK [process_exporter : Get checksum list from github] ************************************************************************************************************************************************************
task path: /Users/user/.ansible/roles/process_exporter/tasks/preflight.yml:43
fatal: [ec2-ip.regioncompute.amazonaws.com]: FAILED! => {"msg": "An unhandled exception occurred while running the lookup plugin 'url'. Error was a <class 'ansible.errors.AnsibleError'>, original message: Received HTTP error for https://github.com/ncabatoff/process-exporter/releases/download/v0.7.5/process-exporter_0.7.5_checksums.txt : HTTP Error 404: Not Found"}
The above task fails on OracleLinux7 because of missing dependecies:
policycoreutils-python
libselinux-python
For consideration.
While the default variable is empty, there is no config.yml file so no test coverage of that functionality.
We could follow the project documentation and set a non-empty default
The default config shipped with the deb/rpm packages is:
process_names:
- name: "{{.Comm}}"
cmdline:
- '.+'
Or not. I think it is an open design decision and don't mind either way.
In any case, this issue is now noted and is discoverable if related issues come up in future.
An alternative approach is to tweak the CI test env. Perhaps a non-empty default is simpler. Doing nothing is even simpler :-)
I think the fix is easy. Add notify clause to use the existing handler.
It is not obvious from process-exporter documentation if/that it supports reload. Restart will be sufficient.
I'll make a PR.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.