terms query missing? about elastisch HOT 10 CLOSED

Missing from elastisch.query? Definitely submit a pull request, I believe this query type is fairly recent.

from elastisch.

@mklappstuhl are you going to contribute this? If not, can you at least tell us where the terms query is missing?

from elastisch.

Going to contribute! I've been wrangling with editors (going from vim to
emacs) last couple of days but I'll take a look tomorrow or over the
weekend :)

On Wednesday, July 16, 2014, Michael Klishin [email protected]
wrote:

@mklappstuhl https://github.com/mklappstuhl are you going to contribute
this? If not, can you at least tell us where the terms query is missing?

—
Reply to this email directly or view it on GitHub
#96 (comment)
.

—
Martin
http://martinklepsch.org http://martinklepsch.org?ref=email

from elastisch.

@mklappstuhl hey, we do accept contributions from Vim users ;)

from elastisch.

Haha, yeah. Just gave emacs another concentrated try and that made my
productivity with everything else tank totally :D

On Wednesday, July 16, 2014, Michael Klishin [email protected]
wrote:

@mklappstuhl https://github.com/mklappstuhl hey, we do accept
contributions from Vim users ;)

—
Reply to this email directly or view it on GitHub
#96 (comment)
.

—
Martin
http://martinklepsch.org http://martinklepsch.org?ref=email

from elastisch.

@michaelklishin as it seems the clojurewerkz.elastisch.query/term function automagically becomes a terms query when you supply a collection:

(defn term
  "Term Query"
  [key values & args]
  (merge { (if (coll? values) :terms :term) (hash-map key values) }
         (ar/->opts args)))

I just put together a map on my own when I needed this unknowing that this would work. Maybe it'd be useful to add an alias so that it shows up in the API documentation?

from elastisch.

@mklappstuhl go ahead. A separate function in general should be fine (we can't change term immediately for backwards compatibility).

from elastisch.

I'm not sure. The existing term query properly supports terms queries as
well.
Duplicating that code doesn't sound like the best idea that's why I
suggested aliasing. Therefore no changes in functionality would be made,
everything would stay compatible.

from elastisch.

Fine, just define a function that will call term internally :)

from elastisch.

Fixed by #104. Thanks @mklappstuhl!

from elastisch.