Giter Club home page Giter Club logo

Comments (9)

timgluz avatar timgluz commented on June 26, 2024

i'll digg into that;

from elastisch.

timgluz avatar timgluz commented on June 26, 2024

Hi,

I'm almost done with this task, but I have a few question before i start preparing PR.
Is it fine to add the additional dependency for the Shield plugin?
If not, should I publish it as a separate package?

from elastisch.

michaelklishin avatar michaelklishin commented on June 26, 2024

@timgluz most likely it is, can you elaborate? Is it an open source client library from Elastic? under what license?

from elastisch.

michaelklishin avatar michaelklishin commented on June 26, 2024

Looks like it has a library part but is not open source. I cannot find any license or usage information.
If so, it should be an optional dependency (e.g. something that applications list as dependencies if they want to use Shield). We can also consider making it a separate ClojureWerkz project.

from elastisch.

timgluz avatar timgluz commented on June 26, 2024

Yes, it's a proprietary extension, managed and owned by Elastic and first install includes only 30days trial; source

That's why I am thinking of creating a new project clojurewerkz.elastisch.shield, which could be added as the additional dependency if people want to work with the shield. And another reason is testing - it requires own separate Docker image with custom configuration for users and roles;

from elastisch.

michaelklishin avatar michaelklishin commented on June 26, 2024

@timgluz alright. Should I set up a new ClojureWerkz repo for you then?

from elastisch.

timgluz avatar timgluz commented on June 26, 2024

Yes, please;

from elastisch.

michaelklishin avatar michaelklishin commented on June 26, 2024

@timgluz done: https://github.com/clojurewerkz/elastisch.shield. I'm making sure you have push permissions now.

One question I have w.r.t. Shield support is how we are going to do integration testing if it's a commercial plugin. Not having tests really sucks.

from elastisch.

timgluz avatar timgluz commented on June 26, 2024

Thanks!

I'm adding tests for all the new functionalities and i'm also going to re-use tests from elastisch to test that the Shield clients work as rest-client and native-client.

I'm also going to set up travis for the new project;

from elastisch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.