Elastisch to support a function for escaping a query string? about elastisch HOT 4 CLOSED

I am always on the fence about automatic escaping. The problem is, you can't opt out of it in most libraries. I'd
recommend adding another option to the query string query helper that is a function that performs escaping. By
default it will be elastisch.escape/escape-query-string-characters (from your report) but it will be possible to also
pass in clojure.core/identity.

How does that sound?

from elastisch.

I should have clarified. I was thinking that a user would manually have to call this function and then pass the result to any of the other document finder/search methods (or the query builder). But I'm all for adding an option to the query string helper. As long as the method is accessible to the outside world (which it would be if it lived elastisch.escape/escape-query-string-characters), I think it's ok.

So you'd vote for adding an option (:escape ?) which is a function that will be called on the value of the query option for clojurewerkz.elastisch.query/query-string? When the option is not present, it will default to elastisch.escape/escape-query-string-characters?

from elastisch.

Yes, I'd vote for :escape and elastisch.escape/escape-query-string-characters sounds like a good default.

from elastisch.

Looks like this is now closed with #63

from elastisch.