Hello, I'm not really sure if this can be considered as a bug, but if I test the connection rate performance, after 209 connection without any wait, the server starts rejecting new connections.

In line 57 SimpleSocketTcpListener.cs, if you comment out "CanAcceptConnections.WaitOne();" the server happily accepts 15K new connections. Is there a better way to handle CanAcceptConnections functionality?

Describe the bug
I'm using TPL to send data back and forth as fast as possible with a 3 second wait time after 5 packets are sent. An exception is thrown within the first 30 seconds of running the program.

To Reproduce
Steps to reproduce the behavior:

Client side:

more:
 Parallel.For(0, 5, new ParallelOptions {
  MaxDegreeOfParallelism = 1
 }, async i => {
  packet = new Packet {
   command = "cmd",
    id = Guid.NewGuid(),

    meta = new List < object > {
     "data"
    }
  };

  await SocketClient.SendMessageAsync(JsonSerializer.Serialize(packet));
 });

await Task.Delay(TimeSpan.FromSeconds(3));
goto more;

Server side:
Look at my other comment, send something similar.

Expected behavior
Communication to flow freely with no exceptions.

Desktop (please complete the following information):

• OS: Windows 10

Additional context
Perhaps instead of using Int32 we could move onto Int64?

[12: 22: 31 FTL] Unhandled exception thrown on socket client
Unhandled exception.System.Exception: Object reference not set to an instance of an object.
 -- - > System.NullReferenceException: Object reference not set to an instance of an object.
at SimpleSockets.Client.SimpleSocketTcpSslClient.Receive(IClientMetadata state, Int32 offset)
 -- - End of inner exception stack trace-- -
 at SimpleSockets.Client.SimpleSocketTcpSslClient.Receive(IClientMetadata state, Int32 offset)
at SimpleSockets.Client.SimpleSocketTcpSslClient.ReceiveCallback(IAsyncResult result)
at System.Threading.Tasks.Task. < > c. < ThrowAsync > b__139_1(Object state)
at System.Threading.QueueUserWorkItemCallbackDefaultContext.Execute()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()
System.OverflowException: Arithmetic operation resulted in an overflow.
at SimpleSockets.Messaging.SimpleMessage.ReadData(Int32 receive)
at SimpleSockets.Messaging.SimpleMessage.ReadBytesAndBuildMessage(Int32 receive)
at SimpleSockets.Client.SimpleSocketTcpSslClient.ReceiveCallback(IAsyncResult result)```

Hello,

In the IClientInfo interface there is a property "ClientName". How can I assign a value to this property?

Is it possible to have generics interfaces to send and dispatch incoming messages? I mean, is there a way to register receivers for messages that are of a certain .net type?

I started a lot of tests today using the given examples to avoid other influences. I placed the server on a cloud server. The client is my local computer. Using SSL there is no MessageContract received. If I switch to SimpleSocketTcpClient everything works fine.

It seems there occures a problem when using MessageContracts if the server runs with mono.
If there is anything I can do to help debugging, please tell me!

Hola, first and foremost thank you very much for contributing this codebase to the open-source community. It saved me a lot of frustration right off the bat. However, I'm now running into a issue that I believe is a bug unless I'm misunderstanding the id parameter of the MessageReceived event handler.

To Reproduce

1. Open a Server Listener
2. Open multiple client connections to the given Listener
3. Set a break point on the internal void InvokeMessageReceived(int id, string text) function (called when (State.Header == "MESSAGE") evaluates as true)
4. Have client 1 send multiple messages using SendMessage() to the server

The first message has an id of 1 as expected, but the second message has an id of 2. My understanding is that the id value passed should indicate which client id sent the message. If I've misunderstood the id parameter, please explain the proper use of it, and could you also explain how I might determine which client id sent the message to the Server Listener? Again I was thinking it would be the Id value inside the passed State.

Likewise, the MessageReceived event does not seem to be firing for additional clients. Only the first client seems to raise this event, despite it being attached to the Listener. I believe this is a bug but it's possible that I've modified something and that it may not be reproducible on your end. Please let me know what you are able to find.

Thanks for your time!

Description
If SimpleSockets is used with SSL encryption first everything looks perfect. After clients disconnect and reconnect (restart client app) the server notices that client connected to server. Server also authenticate the client. From that moment on server ignores everything what client trys to send.

To Reproduce
Steps to reproduce the behavior:

1. Edit Examples
   1a. Server.cs -> comment line 31 and uncomment line 32 ; insert a valid certificate
   Line looks like _listener = new SimpleSocketTcpSslListener(@"c:\wrk\a\srv2.pfx","test");
   1b. Client.cs --> comment line 30 and uncomment line 31; insert a valid certificate
   Line looks like: _client = new SimpleSocketTcpSslClient(@"c:\wrk\b\srv2.pfx", "test");

2. Start Server

3. Start Client

4. Send Message from client (press M -> type message)

5. Server receive message

6. Stop Client App

7. Start Client App

Server confirms client again:

Server authenticate certificate of client 1 .
Client 1 with IPv4 has connected to the server.

8. Send Message from client (press M -> type message)
9. Server does nothing...

Expected behavior
Server acts like on the first connection of client

Screenshots
not applicable

Desktop (please complete the following information):

• Testet with MS Win 10 Pro and Ubuntu Linux 18.04 with Mono
• Testet Nugget Version 1.0.1 and latest github source (November 25, 2019)

Describe the bug
Example code for server does not work

To Reproduce
Steps to reproduce the behavior:

1. Copy example of how to create server

Expected behavior
Compiles

Describe the bug
Today I tested your new nuget version 1.1.6 (old Version was 1.1.5 from git clone). I changed nothing on source code but there is thrown an Exception

31.01.2020 17:38:18 [Error] - Die BeginRead-Methode kann nicht aufgerufen werden, wenn ein anderer read-Vorgang ansteht.

31.01.2020 17:38:18 [Debug] - Die BeginRead-Methode kann nicht aufgerufen werden, wenn ein anderer read-Vorgang ansteht.

bei System.Net.Security._SslStream.ProcessRead(Byte[] buffer, Int32 offset, Int32 count, AsyncProtocolRequest asyncRequest)
bei System.Net.Security._SslStream.BeginRead(Byte[] buffer, Int32 offset, Int32 count, AsyncCallback asyncCallback, Object asyncState)
bei System.Net.Security.SslStream.BeginRead(Byte[] buffer, Int32 offset, Int32 count, AsyncCallback asyncCallback, Object asyncState)
bei SimpleSockets.Server.SimpleSocketTcpSslListener.Receive(IClientMetadata state, Int32 offset)
31.01.2020 17:38:18 [Error] - Server Error: Die BeginRead-Methode kann nicht aufgerufen werden, wenn ein anderer read-Vorgang ansteht.

31.01.2020 17:38:18 [Warn ] - Stack Trace follows:
bei System.Net.Security._SslStream.ProcessRead(Byte[] buffer, Int32 offset, Int32 count, AsyncProtocolRequest asyncRequest)
bei System.Net.Security._SslStream.BeginRead(Byte[] buffer, Int32 offset, Int32 count, AsyncCallback asyncCallback, Object asyncState)
bei System.Net.Security.SslStream.BeginRead(Byte[] buffer, Int32 offset, Int32 count, AsyncCallback asyncCallback, Object asyncState)
bei SimpleSockets.Server.SimpleSocketTcpSslListener.Receive(IClientMetadata state, Int32 offset)
31.01.2020 17:38:18 [Info ] - Client ID 1 getrennt: Remote-IP 127.0.0.1 auf Remote-System
31.01.2020 17:38:18 [Debug] - Client ID 1 mit Remote-IP 127.0.0.1 auf Remote-System was removed from client list
31.01.2020 17:38:18 [Debug] - [ListenerLOG: ]Closing socket from client with id:1 and Guid:

To Reproduce
Steps to reproduce the behavior:
SSL

Expected behavior
should work as 1.1.5

Screenshots
not applicable

when running NetCore.Console.Client and connecting to NetCore.Console.Server
there is a list of option of what to send to the server
when an object by pressing O it sends the object but the server doesnt recognize the object as person
but it recognize the object as :
"Received an object of type = Newtonsoft.Json.Linq.JObject"

and the code in
if (obj.GetType() == typeof(Person))
is always false since its not the type of person but as Newtonsoft.Json.Linq.JObject

Is your feature request related to a problem? Please describe.
Implement a feature to disconnect idle clients in SimpleSocketListener base class.

Describe the solution you'd like
Disconnect idle clients in X seconds

Describe alternatives you've considered
Packets that update a dictionary of the last time the keep-alive packet was sent (my own keep-alive packet)

Additional context
N/A

Is your feature request related to a problem? Please describe.
Yes. My project is based around the restart function of the server, aka after the .StartListening(), it would be great to have a .StopListening() method. (Would be great if this feature could also be implemented on the client too)

Describe the solution you'd like
Implementing a .StopListening() function and a .StopClient() function.

Additional content
It would also be great if the server could "kick" a client by disconnecting it, making the disconnect happen on the client side is less secure, would also help when the server is doing the .StopListening() function to "kick" all connected clients.

Thanks for reading 😄

Hi, I have a question.

On client Part:
When I try to set "close parameter" of SendMessageAsync method, to true.
Is thrown this exception:
Exception thrown: 'System.ObjectDisposedException' in System.dll ("Cannot access a disposed object.") | System.ObjectDisposedException

This behavior isn't implemented?
How to fix it?
Thanks.

As far as i can see there wouldn't be any issue to change the target framework to .net standard 2.0. I just tried it (new .net standard project, copy/paste your code) and the only line to change is
using System.Diagnostics.Eventing.Reader;
in AsyncClientServer.Server.AsyncSocketListener which is a unused using.
=> Shouldn't be much work (if you want, i can do it too, just wanted to know, if you would accept it).

As Microsoft is going to dump the .net framework as we know it, this would future prove this code and make it multi platform too.

Describe the bug
Events do not trigger

To Reproduce
Steps to reproduce the behavior:

1. Create a project with framework 4.7.2
2. Create a SimpleSocketTcpClient
3. Bind events (AuthFailed / AuthSuccess for exemple) and send console writeline to test
4. Start the client
5. Events do not trigger

Expected behavior
Events being triggered

Desktop

• OS: Windows 10
• .NET 4.7.2 framework

Additional context
I tried 4 events (AuthFailed / AuthSuccess) & (ServerConnected & ServerDisconnected)
Only ServerConnected is working.
When my server is down and trying to connect to it with AuthFailed event nothing is triggered.

Thanks for your help! I love your library (I was looking for one which is simple to use) Thanks :)

My code:
public MainWindow() {
InitializeComponent();

        Start();

    }

    private void Start() {

        // Initialization
        SimpleSocketClient client = new SimpleSocketTcpClient();

        // Events
        client.AuthFailed += ClientOnAuthFailed;
        client.AuthSuccess += ClientOnAuthSuccess;

        // Start
        Console.WriteLine("Connecting...");
        client.StartClient("127.0.0.1", 1000);

    }

    private void ClientOnAuthFailed() {
        Console.WriteLine("Failed to authenticate.");
    }

    private void ClientOnAuthSuccess() {
        Console.WriteLine("Authenticated with success.");
    }

`

Description
When trying to create a TcpServer the server doesn't start or doesn't give an error

Steps to reproduce the behavior:

Expected behavior
Server should start and client should be able to connect

Desktop:
Windows 10
Visual Studio 2019

Is your feature request related to a problem? Please describe.
It would be nice to have a Client.OnConnectionFailure event so we could make it stop reconnecting or add other stuff

Describe the solution you'd like
Like mentioned above the addition of a Client.OnConnectionFailure event handler would be it

Describe alternatives you've considered
I could make the reconnect timer 0 and then manually close/dispose the client but then I would have to keep declaring it in order to reuse it

Additional context
I have been learning how to code by myself so if I am missing something please let me know, thanks in advance :)

Hi, I downloaded the new version and I noticed that if you try to use the files in Winforms it contains the following errors in compilation:

1. The name 'ZipFile' does not exist in the current context.
2. The type or space name of the name 'ZipArchive' was not found.

In the previous version using Winforms returned no error.

In a current project I need to provide the certificate content from string. Writing the certificate content into a file and load it again is just bugy...

So I would be very happy if a SimpleSocketTcpSsl Constructor provides the possibility to do that. Providing an X509Certificate2 Object to Constructor would be imho just as good as providing the content as sting.

Hello Cloet, I'm creating this issue not because I have a problem with your library (which is awesome by the way, and even the most complete one ^^), but because I have a request for an addition

I wanted to ask you if it was possible to add a small option, which would be the support of proxies.
I don't know much about networking, so I don't know if it's possible with TCP/UDP.
But if it's possible it would be great if it could be implemented! :)

And thanks again for your library, with the rewrite it will be even better :)
Goodbye! ^^

Hi, how can I stop the server completely?

Hi, if i use this for start the server:
"string ip = "192.168.1.177";
int port = 1234;
listener.StartListening(ip, port);"
In the file "AsyncSocketListener.cs" on line 54 return this exception: System.IndexOutOfRangeException: 'index was outside the bounds of the array'