clightning4j / lamp Goto Github PK

Today I walk inside Reddit and I discovered this post

I think this functionality is easy to add inside the new parse() method to analyze the correct operation todo if I scan some qr code.

example of qt available here

I think this issue can be marked "good first issue" :)

When launching lamp, lightningd is launched automatically (great!). However, if i try to access the settings or the log during startup the app will crash. This does not happen with autostart disabled.

I'd like to switch to Lamp as my main wallet but too many people are still using onchain payments.

Hint: you can use the withdraw RPC command under the hood to spend from lightningd's onchain wallet.

As with fundchannel, it would be great to be able to withdraw [address] all from the dialog without having to use the console

I encounter an error at launch : Tor start failed.
Trying to check the logs I get No log file found.

I run Android 7.1.1 on a BV9000.

Trying with Orbot and activating local proxy I got Lightning start failed, but I still cant check the logs.

My channel amount is shown next to the lock icon which seems to aim to represent onchain funds.

I cannot scan QRcodes of the form lightning:bolt11 anymore. I'm pretty sure i could about a month ago. I get a "could not parse destination address" error.

Hi,

I'm eager to test this but have unfortunately no experience building Android Java projects.
Could you add the build instructions please ?

I'd also like to make it hit my own Esplora instance, is there an option ?

Add a preference in the menu to enable autostart: when app is open, it start automatically tor/lightning daemons.

Looks like it's already part of lightning_ndk, which just has to be released

Update clightning to v0.9.0 and esplora compatible plugin.

Testing binaries available at
https://github.com/lvaccaro/lightning_ndk/releases/tag/release_clightning_0.9.0

I poll the logs and getinfo using the console to check if I'm synced with my Bitcoin backend.

An input on the home screen indicating I'm synced would be nice to have :-)

While there were no update to my balance.

Would Lamp check if I'm not running the latest lightningd binaries ? And if so would it be downloading them on startup ?

When 'lightningd` is already running well and synchronizing, this is the screen I see:

The decimal points are misleading. Choose to either show the American way (where comma delimits thousands and dot delimits decimals) or the French way (where thousands are delimited by an empty space and comma is used to delimit decimals), example:

Represented number is 125023/10

American way:
   12,502.3

French way:
   12 502,3

If I remember correctly. And the names are just how they taught us at school here in central Europe… (no harm or national preference intended).

Actually you may use some "Android Locale" settings (equivalent of LC_* environment variables in glibc-Linux).

I did not have time to really test Lamp yet (will do soon tho), but wanted to know if you already tried to sync gossip on mainnet and how it went.

If it's not feasible, we could use a nice hack to outsource the getroute (which will be called by pay itself) by using the rpc_command hook.

Hi,

I could finally get back to test Lamp 💡 !
I run Android 7.1.1 on a BV9000.

What doesn't work :

• The last release broke my access to the log screen (I can still use getlog on the console though). EDIT: I need to test again, but iirc it made the app crash. This is because i was using IO logging. Too many loglines still makes the app crash.
• I cannot start with Tor enabled (I guess it's related to https://github.com/lvaccaro/esplora_clnd_plugin/issues/1 ?). Solved !
• I still have the Android notification (the one I cannot swipe out) saying I've Tor running from Lamp after disabling it (but it's still disabled : I can start). FIXED
• Erasing the datadir doesn't work (I still have the same node id after console => stop => settings => erase data dir => force stop app => restart. FIXED

What works :

• Both testnet and mainnet work.
• Exporting data works
• Console works
• Persistent data dir across restarts

What would be great to have :

• Specifying my own Esplora instance. Works !
• An "all" button in the fundchannel dialog to fund a channel with all available sats. Works !
• A "private" checkbox in the same dialog. Works!
• Error popups lasting longer (I'm barely able to read most of them)
• Have a file explorer to specifying the import data (I was too lazy to look for the path to the zip file totest the import features). Works!
• An exit button It's the lamp itself !

Now time to test with 10$ worth of bitcoins :-)

Version 3.5 (released 2 days ago) still has versionCode set to 34 – as has version 3.4 from last year, hence Android won't see it as an update. Please remember to increase versionCode directly before releasing a new version 😉 Thanks!

1. Scan QR code of the other node you want to connect to (containing nodeid@address)
2. Fund a channel
3. See the input fields stay on screen

I think the input fields should disappear after FUND CHANNEL button is pressed and the screen should return to the main screen.

I noted that inside log the result is under hexadecimal, I want ask why? there is some rules of Android ndk? or some change inside lightnind to compile it for android?

For more info: lvaccaro/lightning_ndk_forked#5

The last version of esplora plugin (v 0.1) gives the possibility to configure the correct URL with the lightnind configuration.

This issue is a propose to add some configuration extra to Lamp settings to set up a personal endpoint or use the default endpoints

Hi! The older version of lamp which used lightningd 0.9.1 also had bitcoin-cli and could connect to local network bitcoind -testnet node over RPC. After upgrade I get this error in the log:

/data/data/com.lvaccaro.lamp/no_backup/lightningd/../plugins/bcli: 
bitcoin-cli not found. Is bitcoin-cli (part of Bitcoin Core) available in your PATH?
Make sure you have bitcoind running and that bitcoin-cli is able to connect to bitcoind.
You can verify that your Bitcoin Core installation is ready for use by running:
    $ /data/data/com.lvaccaro.lamp/no_backup/bitcoin-cli -testnet -datadir=/data/user/0/com.lvaccaro.lamp/no_backup/.bitcoin -rpcconnect=192.168.1.58 -rpcport=18332 -rpcuser=... -rpcpassword=... echo 'hello world'
2021-03-07T14:15:28.993Z INFO    plugin-bcli: Killing plugin: Plugin exited before completing handshake.
The Bitcoin backend died.

Esplora is giving us estimates way higher than bitcoind, and as we lag to smooth feerate my channels often are unilaterally closed after a "long" (like few days) periods of disconnection and feerate spikes.

Potential solutions:

• Wait for anchor outputs (poor me until then)
• Unreasonably set ignore-fee-limits
• A combination of both ?
• Hack a workaround in the Esplora plugin.

Don't know if it comes from my mobile or from Lamp but i have a hard time scanning bolt11 QR codes: my camera does not focus.

Looks like you forgot to adjust versionCode and versionName before building the APK for v3.5:

package: name='com.lvaccaro.lamp' versionCode='34' versionName='3.4'

Can you please fix that and replace the APK? The current one wouldn't be considered an update by Android and thus not suggested to the user. Thanks!

The screen of the turned off lamp does not show anymore when i stop Lamp (current master). It gets frozen on the last active screen.

After an upgrade to latest master (ce98119) the lamp is not starting properly.
It seems to notice lightningd is old so it downloads the new archive and then tries to uncompress it.
Without success. It does not start. The lamp blinks like if it was doing something. No log of what is happening (or at least I do not know how to get it).