client9 / reopen Goto Github PK

 func (bw *BufferedFileWriter) flushDaemon(interval time.Duration) {
      for range time.NewTicker(interval).C {
               bw.Flush()
      }
}

If bw is closed the flush buffer will continue to be called. Not sure what happens if the original object gets reaped (does goroutine still run? do want to find out!)

need to do comment directives since some errors are ignored intentionally

https://github.com/alecthomas/gometalinter#comment-directives

caller could do this bw.BufWriter.Flush and corrupt state. There is no need for this to be public and confuses the interface. Likewise with OrigWriter.

// BufferedFileWriter is buffer writer than can be reopned
type BufferedFileWriter struct {
        mu         sync.Mutex
        OrigWriter *FileWriter
        BufWriter  *bufio.Writer
}

Need something like this from https://github.com/golang/glog/blob/master/glog.go

// flushSyncWriter is the interface satisfied by logging destinations.
type flushSyncWriter interface {
	Flush() error
	Sync() error
	io.Writer
}