Giter Club home page Giter Club logo

clearbit-java's People

Contributors

chadworth avatar harlow avatar jmiller656 avatar rraman avatar tringuyen1401 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

clearbit-java's Issues

Suggestions

The docs should mention having a separate person and company API.

And there should be an SDK for Name To Domain API.

Support webhook calls

Currently only the streaming calls are supported. Webhook calls should be supported as well

Publish Maven Artifacts

Ticket has been submitted (https://issues.sonatype.org/browse/OSSRH-18525) and now need to follow the remaining steps:

Is outdated Java version used for this client?

Java sources of your library contains the code like:

List<Pair> params = new ArrayList<Pair>();
// ...
Map<String, String> headerParams = new HashMap<String, String>();
// ... e.t.c.

(no diamond operator used) which means you are using something even older that Java 1.7 - probably Java 1.6.

Also I can see JodaTime library in dependencies, which also proves the theory about quite old Java version.

So my question is - do you have any plans to update the client to Java 8 (with removing some old libs like JodaTime)?

Hook up maven build/release to CI

currently this only runs on my laptop; not ideal. if we can get a ci-process setup to autorelease the master branch it would be huge improvement in workflow

Missing Data in Java Client!

Hi guys!

I've been your Java Client for Clearbit now for sometime! Unfortunately though I have noticed an issue:

Take an example response:

{ "id": "16ec9ab7-e185-42e9-b8e3-11710c0b8620", "name": "Ramsdens Solicitors", "legalName": null, "domain": "ramsdens.co.uk", "domainAliases": [ "rice-jones.co.uk" ], "site": { "title": "Ramsdens Solicitors LLP - Huddersfield, Wakefield, Leeds & York", "h1": null, "metaDescription": "Award-winning legal advice from the friendly lawyers at Ramsdens Solicitors. We have offices across Yorkshire. Call us on 01484 821 500 for legal support.", "metaAuthor": null, "phoneNumbers": [ "+44 300 555 0333" ], "emailAddresses": [ "[email protected]", "[email protected]", "[email protected]", "[email protected]", "[email protected]", "[email protected]", "[email protected]", "[email protected]", "[email protected]", "[email protected]" ] }, "category": { "sector": "Industrials", "industryGroup": "Commercial & Professional Services", "industry": "Professional Services", "subIndustry": "Consulting", "sicCode": "73", "naicsCode": "54" }, "tags": [ "Consulting & Professional Services", "B2B", "B2C", "Legal Services" ], "description": "Award-winning legal advice from the friendly lawyers at Ramsdens Solicitors. We have offices across Yorkshire. Call us on 01484 821 500 for legal support.", "foundedYear": 1870, "location": "Oakley House, 1 Hungerford Rd, Huddersfield HX3 5AX, UK", "timeZone": "Europe/London", "utcOffset": 1, "geo": { "streetNumber": "1", "streetName": "Hungerford Road", "subPremise": null, "city": "Huddersfield", "postalCode": "HX3 5AX", "state": "England", "stateCode": "England", "country": "United Kingdom", "countryCode": "GB", "lat": 53.6559612, "lng": -1.8070896 }, "logo": "https://logo.clearbit.com/ramsdens.co.uk", "facebook": { "handle": "ramsdens.solicitors", "likes": 510 }, "linkedin": { "handle": "company/ramsdens-solicitors-llp" }, "twitter": { "handle": "Ramsdens", "id": "48679690", "bio": "Marketing Director @RamsdensLLP. For all your legal needs call 01484 821500, email [email protected] or text LAW 67777 #callRamsdens #RamsdensCSR #teamRamsdens", "followers": 7151, "following": 7831, "location": "West Yorkshire", "site": "https://t.co/lMZ5S8yc6k", "avatar": "https://pbs.twimg.com/profile_images/529930238621265920/Z2XU_ljv_normal.jpeg" }, "crunchbase": { "handle": "organization/ramsdens" }, "emailProvider": false, "type": "private", "ticker": null, "identifiers": { }, "phone": null, "metrics": { "alexaUsRank": null, "alexaGlobalRank": 3150692, "googleRank": null, "employees": 180, "employeesRange": "51-250", "marketCap": null, "raised": null, "annualRevenue": null, "estimatedAnnualRevenue": "$10M-$50M", "fiscalYearEnd": null }, "indexedAt": "2018-03-23T17:30:16.012Z", "tech": [ "digital_ocean", "google_analytics", "microsoft_exchange_online", "outlook", "nginx" ], "parent": { "domain": null }, "similarDomains": [ "armitagesykes.co.uk", "baileysmailes.co.uk", "chadwicklawrence.co.uk", "eatonsmith.co.uk", "holroydsolicitors.co.uk", "honleylaw.co.uk", "smithsolicitorllp.co.uk", "switalskis.com", "tayloremmet.co.uk", "walkermorris.co.uk", "wilkinsonwoodward.co.uk" ] }

Unfortunately the Java client doesn't give us access to 'Similar domains' or 'Email addresses', and also google rank has suddenly disappeared since upgrading from version 0.6 to 0.9.

Can you take a look at this?

Add some tests

It'd be nice to add some tests to prevent regressions. Everything is working well from my own usage, but just a good coding practice. I wouldn't let it block a release to Maven

jersey-core-1.18 does not get pulled in by Maven

@harlow looks like there's still one more issue to figure out in getting this pushed to Maven correctly

When trying to run the client from the version in Maven I get the error:

Exception in thread "main" java.lang.NoClassDefFoundError: com/sun/jersey/spi/MessageBodyWorkers
at com.clearbit.ApiClient.getClient(ApiClient.java:603)
Caused by: java.lang.ClassNotFoundException: com.sun.jersey.spi.MessageBodyWorkers
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 3 more

This is because jersey-core-1.18.jar isn't getting found, so I have to manually add that to my project. I'm not sure what's causing it to get excluded from Maven

Add Combined lookup (person/company)

Currently the repo only has Person -or- Company lookup. We offer a combined person_company lookup which should also be supported in this client library

Cannot authenticate webhooks

Hello,

I have implemented a webhook handler for Enrichment requests in our API codebase, but I am having trouble getting the signature to verify correctly.

I have captured the following request body:

{"id":"db759484-a624-4861-ba27-a2976552e4b4","body":{"person":null,"company":{"id":"a504a1d3-fe1e-472e-9550-d6044f5701ed","name":"Commsor","legalName":null,"domain":"commsor.com","domainAliases":["commsponsor.com"],"site":{"phoneNumbers":[],"emailAddresses":[]},"category":{"sector":null,"industryGroup":null,"industry":null,"subIndustry":null,"sicCode":null,"naicsCode":null},"tags":[],"description":"Commsor
is built by community leaders, for community leaders. That's why we're
creating community-first tools to help you build a better community to
drive customer acquisition, support, retention and
more.","foundedYear":null,"location":"New York, NY,
USA","timeZone":"America/New_York","utcOffset":-4,"geo":{"streetNumber":null,"streetName":null,"subPremise":null,"city":"New
York","postalCode":null,"state":"New
York","stateCode":"NY","country":"United
States","countryCode":"US","lat":40.7127753,"lng":-74.0059728},"logo":"https://logo.clearbit.com/commsor.com","facebook":{"handle":null,"likes":null},"linkedin":{"handle":null},"twitter":{"handle":"Commsor","id":"1108749588142403585","bio":"We
share best practices, tips \u0026 news for community building.
Building software for community managers of all sizes. Tweets by
@j__cub and @theteaguns","followers":186,"following":104,"location":"Remote
🌠","site":"https://t.co/W9FmnErtug","avatar":"https://pbs.twimg.com/profile_images/1215612169569677312/7IwpaveX_normal.jpg"},"crunchbase":{"handle":null},"emailProvider":false,"type":"personal","ticker":null,"identifiers":{"usEIN":null},"phone":null,"metrics":{"alexaUsRank":null,"alexaGlobalRank":1078614,"employees":null,"employeesRange":null,"marketCap":null,"raised":null,"annualRevenue":null,"estimatedAnnualRevenue":null,"fiscalYearEnd":null},"indexedAt":"2020-03-15T11:15:53.949Z","tech":["google_apps","aws_route_53"],"techCategories":["productivity","dns"],"parent":{"domain":null},"ultimateParent":{"domain":null}}},"status":200,"type":"person_company"}

which had the following X-Request-Signature header:

sha1=1f03b7a668a5080a231f6cce7dd2c9882e3a0d57

I have tried to parse this using the WebhookResponseParser class in this clearbit-java library, but I receive the 'bad hmac-sha1 signature' ApiException. I have also tried to calculate the signature by reimplementing the logic in the Java and Ruby libraries using our own crypto libraries but have not managed to generate the correct HMAC.

Thanks
John Preston
Engineer
Commsor

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.