Giter Club home page Giter Club logo

Comments (5)

CleanCut avatar CleanCut commented on June 2, 2024 1

I'm fine with removing the Python 2 code, now. We're ~3 years past it's official EOL.

from green.

CleanCut avatar CleanCut commented on June 2, 2024

I'm not personally interested in this feature. If you (or anyone else) would like to attempt it, the place to start would be in poolRunner. I'd be happy to review the pull request.

from green.

sodul avatar sodul commented on June 2, 2024

@CleanCut I'm considering spending some time to move this forward but since the code handling threads has conditional logic for backward compatibility with older versions of Python (at least it did when I looked into it in 2021), I would like to first refactor the existing code to simplify the logic and only support newer versions. Your test matrix currently includes 3.8, 3.9 and 3.10.

Would you be comfortable with me contributing a few PRs that only ensure support for these versions (and newer of course, like 3.11) ?

from green.

CleanCut avatar CleanCut commented on June 2, 2024

Green currently supports Python 3.5+. I would prefer to not intentionally break support for older versions unless we find a good reason for it.

What if you gave it a try as-is, and then removed the support if it actually caused problems?

from green.

sodul avatar sodul commented on June 2, 2024

I'm only considering removing code for python 2, if that's ok with you.

from green.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.