Giter Club home page Giter Club logo

Comments (7)

sodul avatar sodul commented on June 10, 2024 2

I'm now a maintainer for green on GitHub and Pypi.org. I was able to release v3.5.0 and will look into releasing 4.0.0 with support for Python 3.12 in the next few days.

Thanks @CleanCut !

from green.

CleanCut avatar CleanCut commented on June 10, 2024 1

Thank you for taking this on when life events prevent me from spending the time!

from green.

CleanCut avatar CleanCut commented on June 10, 2024

@sodul Cool, that would be fantastic. I'm going through some major life changes right now, which has made it extremely difficult to keep up with Green.

Go ahead and start by opening some PR's. I'll review them and when a few of those look good, I'll start increasing your permissions and let you act more independently.

from green.

sodul avatar sodul commented on June 10, 2024

@CleanCut I totally understand, life happens. I've added a new PR to address the new warnings with python 3.12. Once 274 and 275 are merged it would be good to get a new official release out.

I did try to add some type annotation a few months back and uncovered a few potential bugs. The issue is that the type annotation available with 3.6 and 3.7 is limited compared to what we can do with 3.8, and there is some code that is different between 3.8 and older versions that makes it even more difficult to get the type annotation to work. So if you are open to it I would request that the next release with the 3.12 compatibility becomes the last release to support 3.6 and 3.7 which are both unsupported upstream. Once I know I do not need to stay compatible with 3.7 I can start refactoring the codebase to use modern type annotation and python 3 syntax. Python 3.13 is deprecating even more old syntax, removing 'dead batteries'.

from green.

CleanCut avatar CleanCut commented on June 10, 2024

Once 274 and 275 are merged it would be good to get a new official release out.

💯 Agreed.

So if you are open to it I would request that the next release with the 3.12 compatibility becomes the last release to support 3.6 and 3.7 which are both unsupported upstream.

I'm fine dropping compatibility for this release. We'll just have to bump major versions if we do that (which is fine).

from green.

sodul avatar sodul commented on June 10, 2024

The most recent release of green, 3.4.3, supports Python 2.7 and IIRC at least Python 3.5. The current main supports 3.6 and 3.7 this is why I think it would be good to do a new green 3.5.0 release which officially drops 2.7 and 3.5, but that folks on 3.6 and 3.7 will be able to use. We can then drop 3.6 and 3.7 in main, I'll cleanup some underlying code and will add modern type annotation.

That's 100% your call, let me know how you want to proceed and I'll be happy to submit a few PRs.

from green.

CleanCut avatar CleanCut commented on June 10, 2024

Sure, that's good advice.

from green.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.