ckingbailey / svbx Goto Github PK

This is throwing a minor error like a notice or a recoverable error. The error log tells me it's on line 19.

Per Felx and JJ's request

Add fields 'def type', 'action owner', and some kind of comments indicator to downloadable csv output of defs table

Clarify: show comment count?

e.g.,

• bart description vta

The fake table layout of the weekly delta report does not use any mobile breakpoints. It doesn't read clearly on mobile. The columns should layout in a more readable way.

screenshot:

Clone def button was removed because cloneDef needs a refactor to take the new required fields

Let this be an opportunity to add more functionality to the Def model so that we have one place for all Def actions like insert, update, fetch, validate, close

As far as I can see it's just the file name is misspelled

These fields seem to be inconsistently recorded. Further investigation needed.

• In defs table view, show download button that exports currently displayed (filtered) data
• formats: csv, json

Some line breaks got converted into \r\n (and variants thereof) upon insertion into db

Add a regex to def update script to purge these characters, and only these characters, when problem defs get updated.

The help page still lists RB as well as my old, internal email. Neither of these items are helpful.

Update to lists JJ and perhaps my personal email

Add document id, document link, evidence type, and evidence repo to csv export

User needs ability to select more than one status from drop down, and filter on them

title display as site url

these pages had title like "Add new def", "Update def"

Please restore those

"Standard-issue" Deficiencies need a field to connect them to a BART deficiency.

The New & Update forms will need form fields to add BART ID.

The simplest way to do with form field would be a select. How difficult would it be to do a searchable select? I recall Semantic UI has one. What other options are out there?

Also add BART ID to search fields above Defs table.

This will require a single-column database migration.

On submitting a new status name thru the form at NewStatus.php, the form target, RecStatus.php, redirects to the non-existent duplicate.php

defs count is getting so numerous as to tax the browser when rendering full defs table.

break defs table up into pages.

this will bugger some things up and take some extra work:

• I believe our mysql connection class can handle pagination. more research necessary
• csv export will need to work differently: pass a query to an endpoint and have the endpoint handle it, rather than passing raw json data to endpoint
• filtration may need some changes. testing necessary

Entering a name that contains a special character, such as ', throws an uncaught exception

To prevent this, escape values entered into the field on any 'Add New ______' form.

Also, please catch that exception, and any others that might be thrown.

It will be necessary to unescape lookup tables values for display.

Right now the controller for /api/defs implements its own code that duplicates some of the code in src/Export.

Instead, use the Export class to accomplish what this API endpoint needs to accomplish. DRY FTW

Right now I have to set this directly in the database.

Instead, the Edit view for System should have a select element where a Lead can be selected from a list of names.

per request of JJ

Change "res. req'd by" to "required by" on filter of that name on defs table

This should be a text field that gets filled with a name or a dropdown where a name can be selected

What does this entail besides adding it to database? What functionality does this come with? Does this new status signify 'open', 'closed', or some other, special, in-between state?

In case an admin is locked out/has forgotten password, we need a script that can be run on command line to create user or reset password.

I have such a script in v2. Would it work here?

As of right now, it'd be easy to add it to the autoload path. I believe that goes under PSR-1

Pointing to the config file remains a problem in v2 because of the nested file structure, and will be an issue here if we start to adopt v2. Likewise pointing to 'vendor/autoload.php' is a problem in v2 for the same reason.

Let's use this thread to discuss possible solutions.

What's happening now

When visiting the site after the session cookie has expired, navbar still display username and full nav options as if user is still logged in. On clicking any of the privileged nav options the user is taken to logout.

The way it should work

• After session cookie has expired the navbar should look like the un-logged-in navbar, presenting "Login" in the top left and a limited set of nav options
• If a user tries to navigate to any privileged endpoint they should be redirected to the login page, rather than to logout

Right now I have to set a user's permission thru the database.

That's no good.

Create an interface for it so other admins can set this user permission themselves.

Replace HTML entities and line break escapes for a more readable experience

I created a mysql view for this, Open deficiencies by system

Ideally, it wants an interface for the web user

When date on a field is '0000-00-00', Twig filter date("n-j-Y") renders it as <this month>-<today>--0001

see: def.html.twig

Known problem filters:

• location
• specLoc
• severity
• id'd by
• system affected
• group to resolve

Session is unexpectedly expiring when user leaves page alone for only a couple of minutes.

Session timer should reset on each user interaction.

💡 Perhaps the reset method is getting called only on certain pages, and not on others?

The app tries to insert a value NOW() in a prepared statement. Mysql won't allow a Mysql function as an insertion value in a prepared statement.

Instead, insert a date string generated by PHP

FILTER_SANITIZE_SPECIAL_CHARS converts null to "". Inserting "" into date fields produces 0000-00-00.

Instead, be more specific with filters.

Chrome won't print def table in landscape. Is it because the document doesn't have a specified width for portrait print so Chrome thinks it's already as wide as landscape?

As it is Twig that iterates over the data for display, we need Twig to unescape strings else characters such as " display as \"

The syntax is something like:

$unescape = new Twig_Filter('unescape', function unescape($string) {
  return strip_cslashes($string);
});

$twig->addFilter($unescape)

see: https://twig.symfony.com/doc/2.x/advanced.html

We need a field to group systems together on. Many systems fit under broad categories. Let's call this field category

Create a migration for this ftw

e.g.,

• bart root problem
• project specLoc

There are a lot of unused files hanging around, including:

• various .sql files
• Duplicate.php
• search.php

This is throwing a recoverable error.

The fix is super simple: set the second parameter of print_r to "true" in to WeeklyData::__toString