Giter Club home page Giter Club logo

expert-sender-api's People

Contributors

alexandrfox avatar amstaffix avatar dnabatchikov avatar liderman avatar macdada avatar nuwak avatar rdmrcv avatar vitkovskii avatar yapro avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

expert-sender-api's Issues

Webmozart\Assert should be a direct dependency

Currently, webmozart/assert is a transitive, likely dev, dependency that might be missing in production environment.

Since it's used ubiquitously throughout the package, it should be listed as a direct dependency in composer.json.

Error in documentation

$receiverByEmail = Receiver::createByEmail('[email protected]', $listId);
$receiverByEmailMd5 = Receiver::createByEmailMd5('md5');
$receiverById = Receiver::createById(862547);

Change to

$receiverByEmail = Receiver::createWithEmail('[email protected]', $listId);
$receiverByEmailMd5 = Receiver::createWithEmailMd5('md5');
$receiverById = Receiver::createWithId(862547);

Error in Add/Edit subscriber documentation

In the code provided to document Add/Edit subscriber:

`
// if you want use another adding mode, create it. It's optional too and by default "AddAndUpdate"
$mode = Mode::ADD_AND_UPDATE();

// you can add more than one subscriber to request
$addOrEditResponse = $api->subscribers()->addOrEdit([$subscriberData], $options, $mode);
`

But it seems there's only two parameters in the method:

`
/**
* Add or edit subscriber
*
* @param SubscriberInfo[] $subscriberInfos Subscribers information list
* @param Options|null $options Options
*
* @return SubscribersPostResponse Response
*/
public function addOrEdit(array $subscriberInfos, Options $options = null): SubscribersPostResponse
{
return new SubscribersPostResponse(
$this->requestSender->send(new SubscribersPostRequest($subscriberInfos, $options))
);
}

`

Please, consider to update documentation.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.