Giter Club home page Giter Club logo

Comments (5)

ciscoheat avatar ciscoheat commented on May 27, 2024 1

Then I guess SvelteKit doesn't take transitions into account for the navigation store. Some future version of Superforms may have a custom callback for when the submission is determined to be completed, but not right now. :)

from sveltekit-superforms.

ciscoheat avatar ciscoheat commented on May 27, 2024

This is already included in the timers, if a redirect result is returned, then the SvelteKit navigation store is used to clear the timers. If that doesn't work for you, something isn't right. Can you make a MRE?

from sveltekit-superforms.

saturnonearth avatar saturnonearth commented on May 27, 2024

This is already included in the timers, if a redirect result is returned, then the SvelteKit navigation store is used to clear the timers. If that doesn't work for you, something isn't right. Can you make a MRE?

Here is a MRE: https://stackblitz.com/edit/superforms-2-testing-qcncdj?file=src%2Froutes%2F%2Bpage.svelte

I wonder if it's because of the page transition?

from sveltekit-superforms.

ciscoheat avatar ciscoheat commented on May 27, 2024

When I submit on the MRE, the spinner is visible up until the transition, isn't that how it's supposed to be?

from sveltekit-superforms.

saturnonearth avatar saturnonearth commented on May 27, 2024

When I submit on the MRE, the spinner is visible up until the transition, isn't that how it's supposed to be?

Well technically speaking I suppose yes, but it's a little jarring during a transition when the button state changes. I could just add a flag but was thinking of a cleaner way to do this as it's a common pattern for me, and I often already have $delayed or $submitting on the submit button - but perhaps it's unnecessary

from sveltekit-superforms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.