Installing Superforms Causes Cloudflare Deployment to Fail about sveltekit-superforms HOT 7 CLOSED

So we can conclude that this is a "feature" for upgrading to the superior pnpm. 😄

from sveltekit-superforms.

Hi, @MattHeslington

This is very strange. I just deployed it, and got the same error 🙁

And as suspected, I switched up npm for pnpm such that I'm deploying a pnpm-lock.yaml instead of a package-lock.yaml, and it works perfectly. 😅

Check here: https://github.com/shyakadavis/superforms-fail-ts

I don't know the internals, but seems that Superforms has better pnpm support than it does npm.

Suggestion:

For now, does using pnpm violate your workflow? Because for me, the merits of using it outweigh the alternatives around. 🤷‍♂️

Anywho, hoping to here Andreas' input on this. 🙂

Thanks for checking it out, I really appreciate it. pnpm doesn't disrupt my workflow at all, I'll use that instead. Thanks for your help 👍🏻

from sveltekit-superforms.

Haven't deployed on Cloudflare before, I think I need a simple repo that reproduces this problem before I can start figuring things out.

from sveltekit-superforms.

Hi;

When I first this, I was worried, first because of the other issues I saw of validators being added regardless of whether you're using them or not, and also because I use CF for all my deployments; but I wanted to let you know that it worked just fine for me, and it might be an isolated issue.

But, to be fair, I didn't set up a complete Superforms flow - just bare necessities to see if I would run into that issue. And of course, I'm using pnpm like everyone else, so maybe it might be an npm issue - who knows 🤷‍♂️

from sveltekit-superforms.

Hi;

When I first this, I was worried, first because of the other issues I saw of validators being added regardless of whether you're using them or not, and also because I use CF for all my deployments; but I wanted to let you know that it worked just fine for me, and it might be an isolated issue.

But, to be fair, I didn't set up a complete Superforms flow - just bare necessities to see if I would run into that issue. And of course, I'm using pnpm like everyone else, so maybe it might be an npm issue - who knows 🤷‍♂️

Cheers. I didn't even implement any flow. It's was just a skeleton SvelteKit project with the single, bare-bones welcome page. Just purely having the dependency in package.json caused the deployment to fail. I couldn't work out what was causing the failure, and had to go through everything one-by-one to find the breakpoint.
Thanks for the info, I shall investigate further this afternoon

from sveltekit-superforms.

Haven't deployed on Cloudflare before, I think I need a simple repo that reproduces this problem before I can start figuring things out.

Apologies for the delay. Here are a couple of sample repos, one JS, one TS. They're both just the 'skeleton' option for SvelteKit projects, with Tailwind added. Superforms is not used anywhere - it's just a dependency in each project. Both TS and JS deployments result in the same error log (above) when superforms is a dependency

JS Repo
TS Repo

from sveltekit-superforms.

Hi, @MattHeslington

This is very strange. I just deployed it, and got the same error 🙁

And as suspected, I switched up npm for pnpm such that I'm deploying a pnpm-lock.yaml instead of a package-lock.yaml, and it works perfectly. 😅

Check here: https://github.com/shyakadavis/superforms-fail-ts

I don't know the internals, but seems that Superforms has better pnpm support than it does npm.

Suggestion:

For now, does using pnpm violate your workflow? Because for me, the merits of using it outweigh the alternatives around. 🤷‍♂️

Anywho, hoping to here Andreas' input on this. 🙂

from sveltekit-superforms.