Circular dependency warning when using @sveltejs/adapter-node about sveltekit-superforms HOT 10 OPEN

Try to reproduce it without Superforms, as it seems related to zod-to-json-schema.

from sveltekit-superforms.

@ciscoheat yeah, I definitely think it's related only to zod-to-json-schema and I think most of users (me included) use it only in superforms and not directly.

That's why I thought of a maybe possible solution of its imports update in superforms (directly to files of it for example) to overcome the Circular dependency warning.

from sveltekit-superforms.

I'm also wondering why I even have this warning, I don't use zod with superforms or anywhere in the app 🤔

from sveltekit-superforms.

@ciscoheat I've checked and when superforms package is added with:

yarn add sveltekit-superforms

seems like all optional packages are installed:

success Saved lockfile.
success Saved 29 new dependencies.
info Direct dependencies
└─ [email protected]
info All dependencies
├─ @gcornut/[email protected]
├─ @hapi/[email protected]
├─ @poppinss/[email protected]
├─ @sideway/[email protected]
├─ @sideway/[email protected]
├─ @sideway/[email protected]
├─ @sinclair/[email protected]
├─ @sodaru/[email protected]
├─ @types/[email protected]
├─ @vinejs/[email protected]
├─ @vinejs/[email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]

from sveltekit-superforms.

All packages are installed, but only the ones used will be bundled. What happens if you uninstall zod-to-json-schema?

from sveltekit-superforms.

Gives an error since I don't use the package directly

from sveltekit-superforms.

I don't get the warning when building, so if you have a repo that reproduces it, I'll take a look.

from sveltekit-superforms.

@ciscoheat sure, I've added a reproduction with screenshot: https://github.com/vladshcherbin/svelte-superforms

from sveltekit-superforms.

As mentioned in the other issue, it doesn't happen when using pnpm. Haven't used yarn (more than when absolutely necessary), so maybe it can be configured to handle it.

from sveltekit-superforms.

This warnings are coming from rollup, I've seen them before in other projects - issue rollup/rollup#1089 and many other issues/questions in google. They can be configured there (even mentioned in rollup docs) but rare libraries throw them.

Surprising pnpm doesn't have them (or somehow suppress), the bundler is the same 🙈

from sveltekit-superforms.