Restore Gradle Cache Test about android-orb HOT 6 CLOSED

@ryanbourdais, please correct me if I'm wrong, but I believe multiple jobs in the orb's test suite already cover this change.

Example: https://app.circleci.com/pipelines/github/CircleCI-Public/android-orb/385/workflows/ff8eaabb-1425-43e1-90be-da5e3db7528f/jobs/6008

from android-orb.

@EricRibeiro we had a conversation yesterday in the images meeting about adding an explicit test to restore_gradle_cache because currently
its only called by other commands with overrides to the default parameter value. So there is no case that it runs in its default state

from android-orb.

its only called by other commands with overrides to the default parameter value

What is overriding the default parameter value in the link I shared above?

from android-orb.

@EricRibeiro you're right that one isn't overriden, I must have overlooked it when I was checking yesterday. I'm now extra confused on how the error wasn't caught in testing.

from android-orb.

I'm now extra confused on how the error wasn't caught in testing.

The author mentioned this in #49:

I also observed that, for the "test-emulator-commands" job triggered from PR #48, it somehow did not pick up the code changes from #48 and this ran fine;
It was running with the restore-gradle-cache command from v2.1.0 instead.
We can see this under the config, when clicking on "Compiled":
https://app.circleci.com/projects/github/CircleCI-Public/android-orb/config/?branchName=&pipelineNumber=329

I am not sure what caused the issue above, but it's the reason the tests didn't pick up the error.

from android-orb.

Just going to close this for now. Not sure what to do with this at the moment and there hasn't been any customer complaints.

from android-orb.