Comments (6)
@ryanbourdais, please correct me if I'm wrong, but I believe multiple jobs in the orb's test suite already cover this change.
from android-orb.
@EricRibeiro we had a conversation yesterday in the images meeting about adding an explicit test to restore_gradle_cache because currently
its only called by other commands with overrides to the default parameter value. So there is no case that it runs in its default state
from android-orb.
its only called by other commands with overrides to the default parameter value
What is overriding the default parameter value in the link I shared above?
from android-orb.
@EricRibeiro you're right that one isn't overriden, I must have overlooked it when I was checking yesterday. I'm now extra confused on how the error wasn't caught in testing.
from android-orb.
I'm now extra confused on how the error wasn't caught in testing.
The author mentioned this in #49:
I also observed that, for the "test-emulator-commands" job triggered from PR #48, it somehow did not pick up the code changes from #48 and this ran fine;
It was running with the restore-gradle-cache command from v2.1.0 instead.
We can see this under the config, when clicking on "Compiled":
https://app.circleci.com/projects/github/CircleCI-Public/android-orb/config/?branchName=&pipelineNumber=329
I am not sure what caused the issue above, but it's the reason the tests didn't pick up the error.
from android-orb.
Just going to close this for now. Not sure what to do with this at the moment and there hasn't been any customer complaints.
from android-orb.
Related Issues (20)
- Save-grade-cache command fails when /tmp/gradle_cache_seed file does not exists. HOT 4
- `find` Error when using restore-gradle-cache command from v2.1.1
- `wait-for-emulator` hangs on Android API Level 31 HOT 4
- How can attach screenshots of ui test executions with android/start-emulator-and-run-tests command? HOT 8
- Add adb pull destination folder HOT 1
- Passing environment variables to `start-emulator-and-run-tests` arguments causes job to fail as of 2.1.1 HOT 5
- How to run "adb shell settings put secure long_press_timeout 2000" before execution of test HOT 3
- fastlane-deploy command does not exist HOT 4
- Trying to create AVD in the background results in failure HOT 2
- Options "no-output-timeout" not being used by run-tests command HOT 1
- android/create-google-play-key does not print contents of the environment variable to JSON file HOT 1
- Java 17 is not being set to the environment HOT 3
- pre-test-command gets error `environment: line 8: mvn: command not found` HOT 5
- Using newer version of Android SDK causes emulator booting for too long HOT 6
- Android Gradle plugin requires Java 17 to run. You are currently using Java 11. HOT 2
- cgroup changed for latest orb version? HOT 3
- Latest Orb Does Not Work HOT 1
- Job rejected because resource class doesn't exist for android-machine with latest orb version HOT 5
- NDK path is not correct
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-orb.