Giter Club home page Giter Club logo

Comments (7)

heiningair avatar heiningair commented on July 16, 2024 1

@cinar thanks for the quick reply!

yeah indeed tricky sometimes..

I will try your suggestion with a new project and report what i`ve found

from indicator.

cinar avatar cinar commented on July 16, 2024

Ah, having a v2 turned out to be tricky in Golang. Thank you very much for reporting this. Let me take a quick look.

from indicator.

cinar avatar cinar commented on July 16, 2024

Just did something quick as a new project:

go mod init github.com/cinar/x

Added a quick file:

main.go:

package main

import (
        "fmt"

        "github.com/cinar/indicator/v2/trend"
)

func main() {
        macd := trend.NewMacd[float64]()
        fmt.Printf("%d", macd.IdlePeriod())
}

Go mod tidy seems to be working for me, but I'm on Go 1.22.1, I wonder if that plays a role.

$ go mod tidy
go: finding module for package github.com/cinar/indicator/v2/trend
go: found github.com/cinar/indicator/v2/trend in github.com/cinar/indicator/v2 v2.0.1

Would you mind trying with an empty project to see if it will make a difference?

from indicator.

heiningair avatar heiningair commented on July 16, 2024

ok.. thanks, it seems to work with a new project. investigating further from here. I might be missing something in my other project then..

from indicator.

heiningair avatar heiningair commented on July 16, 2024

I think I got it now.. I had a few lines in there still using the library like in v1

example -> indicator.Ema(...)

this seems to prevent it from pointing to the actual dep when doing a "go mod tidy"

from indicator.

cinar avatar cinar commented on July 16, 2024

from indicator.

heiningair avatar heiningair commented on July 16, 2024

I will definitely let you know as soon as I migrated completely.

As you mentioned, these are breaking changes, but at first glance, it looks a lot nicer! I waited for this for a while already ;)

Thx for your work :)

from indicator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.