Comments (6)
cinar
commented on June 24, 2024
1
It is a good point. I can see that it does make sense for crypto data. Let me see if I can change this.
from indicator.
cinar
commented on June 24, 2024
1
Awesome, please try it with release v1.3.0.
from indicator.
cinar
commented on June 24, 2024
Hi @larscom, when I started building this project, the data source that I used for the data had the volume as int64, so I followed that convention. However, it is a good point. What data source you are seeing volume as float64? I can certainly make it a float64 moving forward too?
from indicator.
larscom
commented on June 24, 2024
hi @cinar, my data source is binance or bitvavo (crypto). Their volume is always a floating point number. Besides that i think it makes sense to make volume a float64 anyhow.
from indicator.
cinar
commented on June 24, 2024
Hi @larscom, please check the fix-126 branch and let me know if it solves the problem for you.
from indicator.
larscom
commented on June 24, 2024
Hi @larscom, please check the
fix-126branch and let me know if it solves the problem for you.
Looking good to me!
from indicator.
Related Issues (20)
- Bollinger Bands standard deviation calculation is different from other implementations HOT 5
- Rename Std to StdFromSma and have a Std function without the Sma provided HOT 1
- Vwma indicator HOT 2
- projectionOscillator returns values less than 0(minimum), and returns values grater than 100(maximum)
- Restructure Candlestick HOT 1
- StochasticOscillator returns NaN for D HOT 4
- Aroon Indicator HOT 2
- Getting invalid SMA's HOT 1
- Add Generator support for streams HOT 1
- Setup dependabot
- Dependabot for GitHub actions.
- Implement the Larry Connors the 2-period RSI strategy #69
- (CRT-P0003) Function params involve heavy amount of copying
- Enable the Go Report Card Badge.
- Enable Coveralls Test Coverage Badge.
- Check if codecov is better.
- Remove the Coveralls from the travis configuration.
- Go Report Card warning: "substract" is a misspelling of "subtract" (misspell)
- Replace Travis CI with GitHub Actions.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from indicator.